nixos/iso-image: fix 32bit UEFI boot #47196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UEFI iso image for i686 didn't boot because the default boot file was incorrectly named bootx32.efi. The correct name is bootia32.efi.
|
cc @samueldr |
Artist's rendition of how I feel
Verified to work with QEMU (looked into making qemu boot 32 bit UEFI).
Where the OVMF path is from With current master / current nixos-unstable it hangs on the Tianocore EFI screen. 👍 and backporting. |
|
[release-18.09 73ceb77] nixos/iso-image: fix 32bit UEFI boot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The UEFI iso image for i686 didn't boot. Because the default boot file was incorrectly named
bootx32.efi, the firmware didn't find it and dropped down to the UEFI shell.This caused two tests to fail:
tests.boot.uefiUsb.i686-linuxandtests.boot.uefiCdrom.i686-linuxThe correct name for 32bit is
bootia32.efi(which is a little inconsistent withbootx64.efifor 64bit.)ZHF #45960, please backport.
Things done