Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desync: init at 0.3.0 #47195

Merged
merged 1 commit into from Sep 22, 2018
Merged

desync: init at 0.3.0 #47195

merged 1 commit into from Sep 22, 2018

Conversation

charles-dyfis-net
Copy link
Contributor

Introduce desync, an alternate implementation of casync

Motivation for this change

nixpkgs presently contains an implementation of casync. casync is a great tool, but its error-handling, performance and ease of code modification can leave something to be desired.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

And I almost forgot: you need to add your package to pkgs/top-level/all-packages.nix to be found at all.

@charles-dyfis-net
Introduce desync, an alternate implementation of casync
76fb7b6 
desync isn't as feature-rich as casync, but has a focus on production usability
and implementation quality which may make it a more appropriate tool.
@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

Let's try and have the bot build it:
@GrahamcOfBorg build desync

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: desync

Partial log (click to expand)

find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
find: '/nix/store/r55rcpac935zyqghfs4jj75kpbzl3y9j-desync-0.3.0': No such file or directory
/nix/store/9psxprjly1parfk0wsx7svj1fcqjli8s-desync-0.3.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: desync

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xq4mdkjafxnp382xcm3sqrp02mcxkj0k-desync-0.3.0-bin
shrinking /nix/store/xq4mdkjafxnp382xcm3sqrp02mcxkj0k-desync-0.3.0-bin/bin/desync
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xq4mdkjafxnp382xcm3sqrp02mcxkj0k-desync-0.3.0-bin/bin
patching script interpreter paths in /nix/store/xq4mdkjafxnp382xcm3sqrp02mcxkj0k-desync-0.3.0-bin
checking for references to /build in /nix/store/xq4mdkjafxnp382xcm3sqrp02mcxkj0k-desync-0.3.0-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/xq4mdkjafxnp382xcm3sqrp02mcxkj0k-desync-0.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: desync

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4lv98sjhcqz0dx7xnb8h84gzsky0abs1-desync-0.3.0-bin
shrinking /nix/store/4lv98sjhcqz0dx7xnb8h84gzsky0abs1-desync-0.3.0-bin/bin/desync
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4lv98sjhcqz0dx7xnb8h84gzsky0abs1-desync-0.3.0-bin/bin
patching script interpreter paths in /nix/store/4lv98sjhcqz0dx7xnb8h84gzsky0abs1-desync-0.3.0-bin
checking for references to /build in /nix/store/4lv98sjhcqz0dx7xnb8h84gzsky0abs1-desync-0.3.0-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/4lv98sjhcqz0dx7xnb8h84gzsky0abs1-desync-0.3.0-bin

xeji
xeji approved these changes Sep 22, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xeji xeji merged commit bd13ef5 into NixOS:master Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@charles-dyfis-net @xeji @GrahamcOfBorg @Janik-Haag