Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnuradio-limesdr: init at 1.0.0-RC #47176

Merged
merged 1 commit into from Sep 23, 2018
Merged

gnuradio-limesdr: init at 1.0.0-RC #47176

merged 1 commit into from Sep 23, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

This gnuradio module adds source and sink blocks for LimeSDR devices.

Things done

Tested with a LimeSDR-mini

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnuradio-limesdr

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC
shrinking /nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC/lib/libgnuradio-limesdr.so
shrinking /nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC/lib/python2.7/site-packages/limesdr/_limesdr_swig.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC/lib
patching script interpreter paths in /nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC
checking for references to /build in /nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC...
/nix/store/kmcr0w06sskpy8262fajh1aprhdpy0rb-gnuradio-limesdr-1.0.0-RC

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnuradio-limesdr

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC
shrinking /nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC/lib/python2.7/site-packages/limesdr/_limesdr_swig.so
shrinking /nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC/lib/libgnuradio-limesdr.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC/lib
patching script interpreter paths in /nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC
checking for references to /build in /nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC...
/nix/store/gnb41x51rl7717idzdaayy6m7j1my099-gnuradio-limesdr-1.0.0-RC

xeji
xeji reviewed Sep 22, 2018
View reviewed changes
pkgs/applications/misc/gnuradio/limesdr.nix Outdated

buildInputs = [
cmake boost gnuradio limesuite
] ++ stdenv.lib.optionals pythonSupport [ python swig ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake definitely belongs in nativeBuildInputs. I'm not sure about swig - is it used at runtime or only at buildtime?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for cmake. That was a copy'n paste mistake (it's wrong in all other gr modules). With swig I am not a 100% sure but there are some derivations that put into nativeBuildInputs.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnuradio-limesdr

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC
shrinking /nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC/lib/python2.7/site-packages/limesdr/_limesdr_swig.so
shrinking /nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC/lib/libgnuradio-limesdr.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC/lib
patching script interpreter paths in /nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC
checking for references to /build in /nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC...
/nix/store/nw87lmp1l4nx08ngg892dwc5cxzyd637-gnuradio-limesdr-1.0.0-RC

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnuradio-limesdr

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC
shrinking /nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC/lib/python2.7/site-packages/limesdr/_limesdr_swig.so
shrinking /nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC/lib/libgnuradio-limesdr.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC/lib
patching script interpreter paths in /nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC
checking for references to /build in /nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC...
/nix/store/b4zcf1ki60wnnry6jp1zid9j92qh5nyy-gnuradio-limesdr-1.0.0-RC

@xeji xeji merged commit 3f883b4 into NixOS:master Sep 23, 2018
@markuskowa markuskowa deleted the gr-limesdr branch September 23, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @GrahamcOfBorg @xeji