Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.26.1 and introduce 0.25.1 #47166

Merged
merged 4 commits into from Oct 2, 2018
Merged

crystal: 0.26.1 and introduce 0.25.1 #47166

merged 4 commits into from Oct 2, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Crystal moves pretty quickly, so not all shards have caught up with the latest version. Here we introduce a generic builder that can be used to build other versions - for now just the latest 0.26.1 as well as 0.25.1

The bootstrap binary is also separated out so we don't have to pull it down every time.

Cc: @manveru @david50407 @sifmelcara

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

srhb
srhb reviewed Sep 22, 2018
View reviewed changes
pkgs/development/tools/build-managers/shards/default.nix Outdated
@@ -1,28 +1,33 @@
{ stdenv, fetchurl, crystal, libyaml, which }:
{ stdenv, fetchFromGitHub, crystal, libyaml, which }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pcre missing here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: crystal, shards

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: crystal, shards

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5cnm3knpsd9l4mysvghk5b7yfinxvs07-shards-0.8.1
shrinking /nix/store/5cnm3knpsd9l4mysvghk5b7yfinxvs07-shards-0.8.1/bin/shards
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5cnm3knpsd9l4mysvghk5b7yfinxvs07-shards-0.8.1/bin
patching script interpreter paths in /nix/store/5cnm3knpsd9l4mysvghk5b7yfinxvs07-shards-0.8.1
checking for references to /build in /nix/store/5cnm3knpsd9l4mysvghk5b7yfinxvs07-shards-0.8.1...
/nix/store/4s2hk41s6sl951i7z9m4drwxb33ibzdv-crystal-0.26.1
/nix/store/5cnm3knpsd9l4mysvghk5b7yfinxvs07-shards-0.8.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: crystal, icr, scry, shards

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: crystal, icr, scry, shards

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3pzz5grjyl61hgxdnbnmva2ix7vw456i-scry
shrinking /nix/store/3pzz5grjyl61hgxdnbnmva2ix7vw456i-scry/bin/scry
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3pzz5grjyl61hgxdnbnmva2ix7vw456i-scry/bin
patching script interpreter paths in /nix/store/3pzz5grjyl61hgxdnbnmva2ix7vw456i-scry
checking for references to /build in /nix/store/3pzz5grjyl61hgxdnbnmva2ix7vw456i-scry...
/nix/store/dcv1h9nq34aw31dw5jh2ddndrvzn2nf7-crystal-0.26.1
/nix/store/cr7pxrz1mhwvaz72983gnps7jxrzwqll-icr
/nix/store/3pzz5grjyl61hgxdnbnmva2ix7vw456i-scry
/nix/store/swswjby35rflm8n7v53yqwfx9flgx21n-shards-0.8.1

@peterhoeg peterhoeg mentioned this pull request Sep 24, 2018
Merged
@sifmelcara
Copy link
Member

Could you please remove me from the maintainer of shards? (Because I don't use crystal anymore) Thanks!
(Also the changes look good to me. I don't have enough memory to build them though)

@peterhoeg peterhoeg changed the title crystal: 0.26.1 and introduce 0.25.1 crystal: 0.26.1 and introduce 0.25.1 [WIP] Sep 25, 2018
@peterhoeg
shards: minor cleanups
b7efce7
@peterhoeg
crystal: 0.26.0 -> 0.26.1
51076b4 
We also start carrying the previous versions as crystal is under rapid
development.

Instead of pulling the binary builder each time, create a derivation that we can
use to build the various versions.
@peterhoeg
icr: init at 0.5.0
5200db3
@peterhoeg
scry: init at 0.7.1.20180919
da61221
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build icr build scry build shards

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: icr, build, scry, build, shards

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@peterhoeg peterhoeg changed the title crystal: 0.26.1 and introduce 0.25.1 [WIP] crystal: 0.26.1 and introduce 0.25.1 Oct 2, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: icr, scry, shards

The following builds were skipped because they don't evaluate on x86_64-linux: build, build

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8nc5sb2254lkm2flsa24y2mjh64w0zcw-icr
shrinking /nix/store/8nc5sb2254lkm2flsa24y2mjh64w0zcw-icr/bin/icr
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8nc5sb2254lkm2flsa24y2mjh64w0zcw-icr/bin
patching script interpreter paths in /nix/store/8nc5sb2254lkm2flsa24y2mjh64w0zcw-icr
checking for references to /build in /nix/store/8nc5sb2254lkm2flsa24y2mjh64w0zcw-icr...
/nix/store/8nc5sb2254lkm2flsa24y2mjh64w0zcw-icr
/nix/store/mqkxkaa0j0qrvhh1a79yzm8rlwqdmrjp-scry
/nix/store/4d14p3r7kkmj0wxli45v82ai22b7s57i-shards-0.8.1

@peterhoeg peterhoeg merged commit 3916f71 into NixOS:master Oct 2, 2018
@peterhoeg peterhoeg deleted the u/crystal branch October 2, 2018 05:29
@peterhoeg peterhoeg restored the u/crystal branch October 3, 2018 04:14
@peterhoeg peterhoeg deleted the u/crystal branch October 8, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @GrahamcOfBorg @sifmelcara @srhb