Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/prosody: use sqlite database #47185

Merged
merged 1 commit into from Sep 23, 2018
Merged

nixos/tests/prosody: use sqlite database #47185

merged 1 commit into from Sep 23, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 22, 2018 •
edited

Motivation for this change

The test didn't catch an issue with luadbi (see #47156) because it used internal storage only. Enable sql (which uses sqlite3 by default) to also test sql access.

Please backport to 18.09 (QA).

Things done

cc @Mic92

@xeji
nixos/tests/prosody: use sqlite database
6e14ae1 
The test didn't catch an issue with luadbi because it used
internal storage only. Switch to sqlite to test sql access.
@xeji
Copy link
Contributor Author

xeji commented Sep 22, 2018

This should fail now because the fix isn't merged yet
@GrahamcOfBorg test prosody

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.prosody

Partial log (click to expand)

error: Attempt to end element "line" with "nest" tag at /nix/store/6la3my7rbnp247nwyhh2ym3v0l47d98j-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
Attempt to end element "line" with "nest" tag at /nix/store/6la3my7rbnp247nwyhh2ym3v0l47d98j-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
cleaning up
killing machine (pid 597)
Attempt to end element "line" with "logfile" tag at /nix/store/6la3my7rbnp247nwyhh2ym3v0l47d98j-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 27.
END failed--call queue aborted, <__ANONIO__> line 1080.
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/glff0szjdzxb49bpa2kwlsf3fw01l5wl-vm-test-run-prosody.drv' failed with exit code 22
error: build of '/nix/store/glff0szjdzxb49bpa2kwlsf3fw01l5wl-vm-test-run-prosody.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tests.prosody

Partial log (click to expand)

error: Attempt to end element "line" with "nest" tag at /nix/store/4iwbarjxa3g6xp5dk6zw8f2idb1rn7s9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
Attempt to end element "line" with "nest" tag at /nix/store/4iwbarjxa3g6xp5dk6zw8f2idb1rn7s9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 53.
cleaning up
killing machine (pid 631)
Attempt to end element "line" with "logfile" tag at /nix/store/4iwbarjxa3g6xp5dk6zw8f2idb1rn7s9-nixos-test-driver/lib/perl5/site_perl/Logger.pm line 27.
END failed--call queue aborted, <__ANONIO__> line 649.
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/8kmhlzwdgkhvzbddfniahh9hwfwm0mh7-vm-test-run-prosody.drv' failed with exit code 22
error: build of '/nix/store/8kmhlzwdgkhvzbddfniahh9hwfwm0mh7-vm-test-run-prosody.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Sep 22, 2018

Let's check again after the fix was merged
@GrahamcOfBorg test prosody

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.prosody

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 75.83s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/00zsky462qsrgknf4ly9f8snx0ghp44c-vm-test-run-prosody

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.prosody

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 94.61s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/miykm4x351wxa45zwpzzq8draiq8qwlw-vm-test-run-prosody

@xeji
Copy link
Contributor Author

xeji commented Sep 22, 2018

OK, this demonstrates that the test works 😄

@xeji xeji merged commit 589b290 into NixOS:master Sep 23, 2018
xeji added a commit that referenced this pull request Sep 23, 2018
@xeji
nixos/tests/prosody: use sqlite database (#47185)
2c83b33 
The test didn't catch an issue with luadbi because it used
internal storage only. Switch to sqlite to test sql access.

(cherry picked from commit 589b290)
@xeji
Copy link
Contributor Author

xeji commented Sep 23, 2018

backported 2c83b33

@xeji xeji deleted the p/prosody-test branch September 24, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @Mic92