Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

influxdb: 1.4.1 -> 1.6.3 #47186

Merged
merged 1 commit into from Sep 23, 2018
Merged

influxdb: 1.4.1 -> 1.6.3 #47186

merged 1 commit into from Sep 23, 2018

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Wanted to use InfluxDB but saw that the version in Nixpkgs was almost a year old (2017-11).

I'm not sure if InfluxDB can be bumped just like this, or if both versions 1.4.1 and 1.6.3 should be made available and a switch is made (in the NixOS InfluxDB service) based on stateVersion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg build influxdb

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: influxdb

Partial log (click to expand)

shrinking /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin/bin/influxd
shrinking /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin/bin/store
shrinking /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin/bin/influx_tsm
shrinking /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin/bin/influx_stress
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin/bin
patching script interpreter paths in /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin
checking for references to /build in /nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/b2a0zzch00a7rbi2xqrcdhq7sv0mpid2-influxdb-1.6.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: influxdb

Partial log (click to expand)

shrinking /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin/bin/influxd
shrinking /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin/bin/influx
shrinking /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin/bin/influx_inspect
shrinking /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin/bin/influx_tsm
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin/bin
patching script interpreter paths in /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin
checking for references to /build in /nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/rp32456slbx712x9480166p72qg75fq9-influxdb-1.6.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: influxdb

Partial log (click to expand)

find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
find: '/nix/store/p1h1p6a14v8xvcjx1b8akq73824a7lp2-influxdb-1.6.3': No such file or directory
/nix/store/wy8mn1fp4jyba2lfpvsxy0axr0x9ahp0-influxdb-1.6.3-bin

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@markuskowa beegfs ist the only user of this in nixpkgs. I tried to build it on top of this PR and got 1 failed test. Not sure if that is related to the influxdb bump. Can you please have a look before this is merged?

@markuskowa
Copy link
Member

@xeji I can build beegfs as well as the test nixos/tests/beegfs.nix successfully for this PR. Influxdb is only used in the monitoring service in beegfs. I think the update is fine.

@xeji
Copy link
Contributor

xeji commented Sep 23, 2018

Thank you @markuskowa!

@xeji
Copy link
Contributor

xeji commented Sep 23, 2018

I'm not sure if InfluxDB can be bumped just like this, or if both versions 1.4.1 and 1.6.3 should be made available ...

@c0deaddict we generally try to keep only the latest version of a package in nixgpks, unless there's a specific reason to keep older versions, like other packages depending on them. In this case it's fine to bump.

@xeji xeji merged commit 91d9e1e into NixOS:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0deaddict @xeji @GrahamcOfBorg @markuskowa