Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: Add version and meta to buildEnv package #47164

Merged
merged 1 commit into from Sep 22, 2018
Merged

weechat: Add version and meta to buildEnv package #47164

merged 1 commit into from Sep 22, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Sep 22, 2018 •
edited

Motivation for this change

Currently the output from nix search and similar tools are lacking important meta data

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@adisbladis
weechat: Add version and meta to buildEnv package
230fd49 
Currently the output from `nix search` and similar tools are lacking
important meta data
@srhb srhb merged commit 924d90d into NixOS:master Sep 22, 2018
@srhb srhb mentioned this pull request Sep 22, 2018
Closed
9 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/r7d37i8dlw3rb6sdp6nz5xxwvbygv2rq-weechat-2.2' from 'https://cache.nixos.org'...
copying path '/nix/store/7b5agj8f7pgwihnabyilkjgvjpp2vp24-weechat-2.2-guile' from 'https://cache.nixos.org'...
copying path '/nix/store/2rdfxb7y5c5dh702lsdhmnbay7rc6i1i-weechat-2.2-ruby' from 'https://cache.nixos.org'...
copying path '/nix/store/sr1fvic96g9a3wdc4yh63fw3v61fgiyw-weechat-2.2-tcl' from 'https://cache.nixos.org'...
copying path '/nix/store/ki52hv6gf7720wn159hlh5pa0bwmyisz-weechat-plugins' from 'https://cache.nixos.org'...
building '/nix/store/gssm6ysd69hn28mixsq81v0l63qgpvxg-weechat-headless.drv'...
building '/nix/store/jr3rpv41bl9y93cqrw2lnh191c07z1cn-weechat.drv'...
building '/nix/store/1v2nms2ih07g36zy8hmz594gc9grw4wg-weechat-bin-env-2.2.drv'...
created 2 symlinks in user environment
/nix/store/8lkxwf68w3zcsjhxn2gbiq3fsjpykkw1-weechat-bin-env-2.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: weechat

Partial log (click to expand)

patching script interpreter paths in /nix/store/9b09ymwjgg2jrgx4r6yvhylvyzi7fll3-weechat-2.2-lua
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/cx7ji5mnarbmrd9qm1navashv3c3lbzd-weechat-2.2-python/lib
patching script interpreter paths in /nix/store/cx7ji5mnarbmrd9qm1navashv3c3lbzd-weechat-2.2-python
building '/nix/store/z9zi7k78xwx2n0pzb9qhg42pcjzlryyl-weechat-plugins.drv'...
building '/nix/store/3d5fjddpysjs5sjj91k61g27n2j9xxgz-weechat-headless.drv'...
building '/nix/store/jqawwvzqxf863wkr7vqfai10zi4qbpjb-weechat.drv'...
building '/nix/store/k6cdggrwkhm5yx4sszkfk13bj1yzsciv-weechat-bin-env-2.2.drv'...
created 2 symlinks in user environment
/nix/store/isxmw84qf3kw8kzfzn1lcn6i5r9rqj0b-weechat-bin-env-2.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1c3drc6cfx3w0xa4hai4ii3gnyb8fhf2-weechat-2.2-python/lib
patching script interpreter paths in /nix/store/1c3drc6cfx3w0xa4hai4ii3gnyb8fhf2-weechat-2.2-python
checking for references to /build in /nix/store/1c3drc6cfx3w0xa4hai4ii3gnyb8fhf2-weechat-2.2-python...
building '/nix/store/qbw49k6igzpsydnqffayybq2pjsi1wdz-weechat-plugins.drv'...
building '/nix/store/xs6rzb3q2d1gs04nfs5z5wwk0p185x6y-weechat-headless.drv'...
building '/nix/store/sqk93cr4z3b5wsq2f1yh2raxyq7dm8j2-weechat.drv'...
building '/nix/store/r3x6i7vvk9cs76plgs3wdr6aj5y36q9m-weechat-bin-env-2.2.drv'...
created 2 symlinks in user environment
/nix/store/0x4rc2jliykv076m0sddvsg6lilkk6z2-weechat-bin-env-2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @GrahamcOfBorg @srhb