Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask_assets: fix tests #47203

Merged
merged 1 commit into from Sep 23, 2018
Merged

pythonPackages.flask_assets: fix tests #47203

merged 1 commit into from Sep 23, 2018

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Sep 23, 2018 •
edited

Motivation for this change

The package tests uses a kwarg that isn't present in Flask 1.0+. Replace it with the correct one.

/cc ZHF #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

r? @abbradar

@xeji
Copy link
Contributor

xeji commented Sep 23, 2018

@GrahamcOfBorg build python27Packages.flask_assets python36Packages.flask_assets

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.flask_assets, python36Packages.flask_assets

Partial log (click to expand)

Regression test: Passing the environment to the ManageAssets command ... ok
tests.test_script.TestScript.test_parse_templates
Test the --parse-templates option. ... ok

----------------------------------------------------------------------
Ran 29 tests in 1.412s

OK
/nix/store/c8qi5ym0h81a98gn0h419flgz6l6l2n4-python2.7-Flask-Assets-0.12
/nix/store/rlzw8j1lb2j1j558582hwi5y44xkahi6-python3.6-Flask-Assets-0.12

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.flask_assets, python36Packages.flask_assets

Partial log (click to expand)

Regression test: Passing the environment to the ManageAssets command ... ok
tests.test_script.TestScript.test_parse_templates
Test the --parse-templates option. ... ok

----------------------------------------------------------------------
Ran 29 tests in 0.291s

OK
/nix/store/x0faxwgn8i7myrxbjkqnkdh9bkaaccyj-python2.7-Flask-Assets-0.12
/nix/store/c49n45yslg2p1hsa4mcaazfh3wwcf39d-python3.6-Flask-Assets-0.12

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.flask_assets, python36Packages.flask_assets

Partial log (click to expand)

Regression test: Passing the environment to the ManageAssets command ... ok
tests.test_script.TestScript.test_parse_templates
Test the --parse-templates option. ... ok

----------------------------------------------------------------------
Ran 29 tests in 1.034s

OK
/nix/store/pcdvpm0q0nfqg4smagqqy18cmj3cafbg-python2.7-Flask-Assets-0.12
/nix/store/m99gq3i2qqx4wqkrf64wp9qavnpza282-python3.6-Flask-Assets-0.12

@xeji xeji merged commit e141f7c into NixOS:master Sep 23, 2018
@andrew-d andrew-d deleted the andrew/flask-assets branch September 23, 2018 08:03
@andrew-d
Copy link
Contributor Author

@xeji - Thanks!

xeji pushed a commit that referenced this pull request Sep 23, 2018
@andrew-d @xeji
pythonPackages.flask_assets: fix tests (#47203)
0d7c472 
(cherry picked from commit e141f7c)
@xeji
Copy link
Contributor

xeji commented Sep 23, 2018

backported to 18.09: 0d7c472

@cript0nauta cript0nauta mentioned this pull request Aug 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-d @xeji @GrahamcOfBorg