Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/containers-restart_networking: disable on Hydra #47183

Closed

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 22, 2018

Motivation for this change

This test has continuously failed since 2017-10-31 and I can't figure out what's wrong (yet).
No point in retrying every time, just a waste of Hydra resources.

ZHF #45960, needs backport.


test has failed since 2017-10-31, no point in retrying every time
@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

FWIW I think this is a real bug where the subsequent reconfigs lose the br0 association on each of the host-side veths. Adding the following after each reconfiguration shows this (cannot restart due to a tmp unmount failure?)

      $client->succeed("systemctl stop container\@webserver");
      $client->succeed("systemctl start container\@webserver");

@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

The comment on the disabled rstp test seems to imply that any restart of br0 will cause the container to lose connectivity. This seems wrong to me?

@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

cc @kampfschlaefer

@xeji
Copy link
Contributor Author

xeji commented Sep 23, 2018

FWIW I think this is a real bug where the subsequent reconfigs lose the br0

I agree. I don't think it's a problem with the test. But still no point running it on Hydra while we know it fails...

@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

@xeji We obviously failed to act on this when it happened, probably because the test has not been in the blocking set. Is there an associated ticket? I don't believe the correct response is to disable it when finally someone has noticed that we actually broke container networking. :)

@srhb
Copy link
Contributor

srhb commented Sep 23, 2018

git bisect reveals that the breaking commit is 07e0c0e

@xeji
Copy link
Contributor Author

xeji commented Sep 23, 2018

@srhb thank you!

@xeji xeji closed this Sep 23, 2018
@xeji xeji deleted the p/disable-containers-restart-networking-test branch September 23, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants