Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eternal-terminal: 4.1.2 -> 5.1.0 #45834

Closed
wants to merge 1 commit into from
Closed

eternal-terminal: 4.1.2 -> 5.1.0 #45834

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from eternal-terminal.

meta.description for eternal-terminal is: '"Remote shell that automatically reconnects without interrupting the session"'.

Checks done (click to expand)
  • built on NixOS
  • /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/etserver passed the binary check.
  • /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/etterminal passed the binary check.
  • /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/et passed the binary check.
  • /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/htm passed the binary check.
  • /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/htmd passed the binary check.
  • 5 of 5 passed binary check by having a zero exit code.
  • 5 of 5 passed binary check by having the new version present in output.
  • found 5.1.0 with grep in /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0
  • directory tree listing: https://gist.github.com/6b97903ce48ee5d72a069273230b85f4
  • du listing: https://gist.github.com/e0539b66fe0cde188ab0693f8dc7a01b
Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

  1. Install cachix from https://cachix.org/
  2. Use r-ryantm's cache: 
    cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:

nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/a59366e784b8af81b2fbc95c035721a1393004d1.tar.gz -p eternal-terminal
ls -la /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0

cc @dezgeg for testing.

eternal-terminal: 4.1.2 -> 5.1.0
a59366e 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
eternal-terminal
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: eternal-terminal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eternal-terminal

Partial log (click to expand)

shrinking /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0/bin/htmd
shrinking /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0/bin/htm
shrinking /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0/bin/et
shrinking /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0/bin/etterminal
shrinking /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0/bin/etserver
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0/bin
patching script interpreter paths in /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0
checking for references to /build in /nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0...
/nix/store/zxwccxmryc4m1zbx03c0a08dbmjmnxx9-eternal-terminal-5.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eternal-terminal

Partial log (click to expand)

shrinking /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/etterminal
shrinking /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/htmd
shrinking /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/et
shrinking /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/etserver
shrinking /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin/htm
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0/bin
patching script interpreter paths in /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0
checking for references to /build in /nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0...
/nix/store/8bcjhllsx7yrfv9zf6q7nryx7i5xbfbx-eternal-terminal-5.1.0

@jtojnar
Copy link
Contributor

jtojnar commented Aug 31, 2018

Possible dependency changes:

jtojnar
jtojnar reviewed Aug 31, 2018
View reviewed changes
pkgs/tools/networking/eternal-terminal/default.nix
@@ -2,13 +2,13 @@

stdenv.mkDerivation rec {
name = "eternal-terminal-${version}";
version = "4.1.2";
version = "5.1.0";

src = fetchFromGitHub {
owner = "MisterTea";
repo = "EternalTCP";
rev = "refs/tags/et-v${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that they use explicit tag, even if there are no potentially conflicting branches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember the particular reason I do it. Was it perhaps that fetchgit doesn't work without refs/tags/? Maybe it's a habit...

@qolii
Copy link
Contributor

qolii commented Oct 16, 2018

Would it be possible to get this one merged? There's actually been some subsequent releases since this update.

Or, should I add an extra commit to this branch to get this up to date?

@jtojnar
Copy link
Contributor

jtojnar commented Oct 16, 2018

This is not ready to be merged. We need someone to modify the buildInputs as described above, test the changes and either open a PR against this branch or better, open a new PR against nixpkgs.

@qolii
Copy link
Contributor

qolii commented Oct 17, 2018

@jtojnar, I see. As far as I can tell, it should just need the removal of glog, right?

I've made this change and it's building happily. However, I am seeing a failure in use: MisterTea/EternalTerminal#106 (comment)

I'll update here when I figure out what the deal is.

@qolii qolii mentioned this pull request Oct 18, 2018
Merged
9 tasks
@qolii
Copy link
Contributor

qolii commented Oct 18, 2018

I've just opened #48648 with (what I think are) the right changes. Please let me know!

@jtojnar jtojnar closed this Oct 18, 2018
@r-ryantm r-ryantm deleted the auto-update/eternal-terminal branch October 24, 2018 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg dezgeg left review comments

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 9.needs: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @GrahamcOfBorg @jtojnar @qolii @dezgeg