New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildbot: use python3Packages #45789
Conversation
I've been running buildbot using Python 3 for nearly a year (see: lopsided98/nixpkgs@7db611f...8853014), but I never submitted the code upstream because I couldn't get tests to pass and also I wrote it when I wasn't very experienced with Nix and never got around to cleaning it up. Yesterday I submitted #45763, which updates sphinx-jinja and adds Python 3 support (mostly the same as your commit). I also updated tempita to use a fork that fixes the tests with Python 3 (see #39692), because tempita is seemingly abandoned. This fork is also used by the official Arch Linux package. Switching to Python 3 has the potential to break deployments because buildbot's configuration files are written in Python. That was why I tried to make the Python version configurable. |
These configuration files are typically quite small and trivial, I suppose? |
Not necessarily, they can get pretty long and complicated. |
In that case we may need to provide version for 2 and 3. Do our maintainers want that? If so, we might want to pull it into |
I can move the package to |
Yes, we can make it configurable using the usual Citing from #45782 (comment)
|
See #45890 |
#45890 was merged a while ago, so this can be closed |
Motivation for this change
fixes #45782
Some tests are still failing, but I don't have enough time right now to fix this. Help is very welcome.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)cc @ian-ross