snakemake: init at 5.2.2 #45828
snakemake: init at 5.2.2 #45828
Conversation
| name = "snakemake"; | ||
| version = "5.2.2"; | ||
| in python3Packages.buildPythonApplication { | ||
| name = "${name}-${version}"; |
There was a problem hiding this comment.
please use pname and version attributes instead of your own name definition
| in python3Packages.buildPythonApplication { | ||
| name = "${name}-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
Any reason not to use fetchFromBitBucket here?
There was a problem hiding this comment.
Nope, only a noob not knowing better. :-)
| @@ -0,0 +1,42 @@ | |||
| { stdenv, fetchurl, python3Packages }: | |||
There was a problem hiding this comment.
Does the author of snakemake say this only works on python3? It seems like you could specify python3 in the top-level/all-packages.nix instead of making this derivation specific.
There was a problem hiding this comment.
Yes, Snakemake requires python >= 3.5.
However, it's makes sense set the python version at top-level/all-packages.nix. Done.
renatoGarcia
force-pushed
the
snakemake
branch
from
91d4f8c
to
d44ff4f
Compare
|
Ops, I didn't search for a snakemake PR before posting this, and did not known of the #45730. Should I remove this PR? |
|
closing as duplicate of #45730 |
Motivation for this change
Adds the snakemake program.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)