Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DappHub projects #47279

Merged
merged 1 commit into from Sep 24, 2018
Merged

Remove DappHub projects #47279

merged 1 commit into from Sep 24, 2018

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Sep 24, 2018 •
edited

Motivation for this change

DappHub maintains a separate overlay at
https://github.com/dapphub/dapptools/blob/master/overlay.nix.

Closes #45696.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@asymmetric asymmetric force-pushed the asymmetric/remove-dapptools branch 3 times, most recently from 98d236e to 1f0c7ea Compare September 24, 2018 15:57
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

cc @dbrock

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

This should be backported to 18.09.

@Mic92 Mic92 merged commit d123b30 into NixOS:master Sep 24, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

backport: 71fd97d

@asymmetric asymmetric deleted the asymmetric/remove-dapptools branch September 24, 2018 22:27
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/the-cache-is-down-not-anymore/1720/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asymmetric @Mic92 @xeji @nixos-discourse @GrahamcOfBorg