Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2fsprogs: patch out glibc instead of local fix so headers are usable #47278

Merged
merged 1 commit into from Sep 24, 2018
Merged

e2fsprogs: patch out glibc instead of local fix so headers are usable #47278

merged 1 commit into from Sep 24, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 24, 2018

Tried to avoid this earlier, but if not patched the headers contain the same
glibcisms and so aren't usable by others.

Apply patch from void instead to make the change propagate.

Staging due to rebuild impact.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: e2fsprogs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: e2fsprogs

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/xcn6dc4kqmbwb29dkw5hyl0m9ac3i04b-e2fsprogs-1.44.4-man
gzipping man pages under /nix/store/xcn6dc4kqmbwb29dkw5hyl0m9ac3i04b-e2fsprogs-1.44.4-man/share/man/
strip is /nix/store/338kyqvbhhyr0qayq3mv01k0axc1sld4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xcn6dc4kqmbwb29dkw5hyl0m9ac3i04b-e2fsprogs-1.44.4-man
checking for references to /build in /nix/store/xcn6dc4kqmbwb29dkw5hyl0m9ac3i04b-e2fsprogs-1.44.4-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/wch2q24a54qb93b6mc4cyz6dxk7x3f4y-e2fsprogs-1.44.4-info
strip is /nix/store/338kyqvbhhyr0qayq3mv01k0axc1sld4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/wch2q24a54qb93b6mc4cyz6dxk7x3f4y-e2fsprogs-1.44.4-info
checking for references to /build in /nix/store/wch2q24a54qb93b6mc4cyz6dxk7x3f4y-e2fsprogs-1.44.4-info...
/nix/store/74bs912nzzn261y13ifa8c5qsxxlbbq7-e2fsprogs-1.44.4-bin

@dtzWill dtzWill mentioned this pull request Sep 24, 2018
Closed
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: e2fsprogs

Partial log (click to expand)

cannot build derivation '/nix/store/1g636il2c01xwwvd3wf0nmgr3m856qqy-python2.7-setuptools-40.2.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/vmgbchiwxv6psl1lgq1jsn7dbgsas7ad-linux-pam-1.3.0.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/5bf7dvb1g32a6b36pf79i0i5amparfjw-perl5.28.0-libwww-perl-6.35.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/8bayr8l841y4dyaxwzj2znpfjjfc9z4v-perl5.28.0-XML-Parser-2.44.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4qhw08ni5ifq5hfv1fxh2a9l45pq38ha-intltool-0.51.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4im8z3fk2lgjvw73fayckwllipyrn56b-gnome-doc-utils-0.20.10.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/5zk5lm09rj60xkgzmks5d0dcv48xyb3m-shadow-4.6.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/mxvr07p2k28s0majxsv0hn78zppp9v46-util-linux-2.32.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/w7535g1niasmymhfaq9qxv22cr7dk81z-e2fsprogs-1.44.4.drv': 7 dependencies couldn't be built
error: build of '/nix/store/w7535g1niasmymhfaq9qxv22cr7dk81z-e2fsprogs-1.44.4.drv' failed

@dtzWill dtzWill merged commit cc2f6c8 into NixOS:staging Sep 24, 2018
@dtzWill dtzWill deleted the fix/e2fsprogs-musl-patch branch September 24, 2018 17:22
@nh2 nh2 mentioned this pull request Sep 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg