Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.33.3.1 -> 0.33.5 #47273

Merged
merged 1 commit into from Sep 24, 2018
Merged

matrix-synapse: 0.33.3.1 -> 0.33.5 #47273

merged 1 commit into from Sep 24, 2018

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Sep 24, 2018

Upgrade matrix-synapse to the latest version,
adding a new required dependency (treq)

  • Builds on NixOS 18.03
  • Runs

It would be nice to back-port this to release-18.09 too if possible.

CC package maintainers: @Ralith @roblabla @Ekleog

@pacien
matrix-synapse: 0.33.3.1 -> 0.33.5
4cd6502 
Upgrade matrix-synapse to the latest version,
adding a new required dependency (treq)
@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

@GrahamcOfBorg build matrix-synapse
@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/lib  /nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin
patching script interpreter paths in /nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5
checking for references to /build in /nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5...
wrapping `/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin/synapse_port_db'...
wrapping `/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin/hash_password'...
wrapping `/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin/synctl'...
wrapping `/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin/register_new_matrix_user'...
wrapping `/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5/bin/homeserver'...
/nix/store/gwg63bdyvjv1jkkxnfmmb0lapd2qw3qd-matrix-synapse-0.33.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serversqlite: exit status 0
serverpostgres: running command: sync
serverpostgres: exit status 0
test script finished in 52.22s
cleaning up
killing serversqlite (pid 597)
killing serverpostgres (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/g9788cjfbdfxvl441yzb8w1jpvrcn2ls-vm-test-run-matrix-synapse

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/lib  /nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin
patching script interpreter paths in /nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5
checking for references to /build in /nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5...
wrapping `/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin/hash_password'...
wrapping `/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin/homeserver'...
wrapping `/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin/register_new_matrix_user'...
wrapping `/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin/synapse_port_db'...
wrapping `/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5/bin/synctl'...
/nix/store/vn4z6d4gpf0war82yax1x9dzqb5qpv6k-matrix-synapse-0.33.5

Ekleog
Ekleog approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

About backporting, I fear it's too late for 18.09 pre-branch-off.

For 18.09 post-branch-off, given the fate of #43889, I don't think it's likely that this will be backported until clear guidelines are set about software whose upstream is unstable.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

serversqlite: exit status 0
serverpostgres: running command: sync
serverpostgres: exit status 0
test script finished in 127.09s
cleaning up
killing serversqlite (pid 631)
killing serverpostgres (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/snlhpc98kf701vvfd578r7ickzy4c4vy-vm-test-run-matrix-synapse

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

In nixos we backport bugfix releases, but not major version that can break stuff. So backporting depends on the nature of this update.

@Mic92 Mic92 merged commit 0a8bbcb into NixOS:master Sep 24, 2018
@pacien
Copy link
Contributor Author

pacien commented Sep 24, 2018

Changelog is here.

This version does include a lot of bugfixes… Just like every other release, given the experimental nature of this software :/

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

Whether this should be backported or the current version in 18.09 is ok, I would leave up to the maintainer: @Ralith @Ekleog @roblabla

@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

This version appears to have no potential backwards-compatibility-breaking changes pointed in the changelog (apart from changes in the log format, which, I think, can be disregarded, and the removal of the nuke-room-from-db.sh script, which doesn't affect us anyway as it doesn't appear to make its way up to the nix package).

As a consequence, I am in favor of backporting to 18.09.

@Mic92
Copy link
Member

Mic92 commented Sep 25, 2018

backport: 5279942

@Ekleog
Copy link
Member

Ekleog commented Sep 25, 2018

Thanks! :)

@Ekleog Ekleog mentioned this pull request Oct 5, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacien @Ekleog @GrahamcOfBorg @Mic92