Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive/combine.nix: drop nix1 support #47294

Merged
merged 1 commit into from Sep 24, 2018
Merged

texlive/combine.nix: drop nix1 support #47294

merged 1 commit into from Sep 24, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 24, 2018

Since 7d1968c ('Nix minimal version: 1.11 -> 2.0') nixpkgs now require nix 2.0+

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl
texlive/combine.nix: drop nix1 support
70a6b68 
Since 7d1968c ('Nix minimal version: 1.11 -> 2.0') nixpkgs now require nix 2.0+
@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

Thank you!
Just to be sure I verified that this is a noop for texlive.combined.scheme-{basic,minimal,full}.

@xeji xeji merged commit 256af6d into NixOS:master Sep 24, 2018
@veprbl veprbl deleted the patch-8 branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @xeji @GrahamcOfBorg