Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.google-compute-engine: fix build #47267

Merged
merged 1 commit into from Sep 24, 2018
Merged

python3Packages.google-compute-engine: fix build #47267

merged 1 commit into from Sep 24, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 24, 2018 •
edited

Motivation for this change

The dependency distro was missing.
See https://hydra.nixos.org/build/81330387

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

@GrahamcOfBorg build python27Packages.google-compute-engine python36Packages.google-compute-engine google-compute-engine

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.google-compute-engine, python36Packages.google-compute-engine, google-compute-engine

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.google-compute-engine, python36Packages.google-compute-engine, google-compute-engine

Partial log (click to expand)

/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510/bin/set_multiqueue: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510...
wrapping `/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510/bin/google_accounts_daemon'...
wrapping `/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510/bin/google_network_daemon'...
wrapping `/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510/bin/google_metadata_script_runner'...
wrapping `/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510/bin/google_instance_setup'...
wrapping `/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510/bin/google_clock_skew_daemon'...
/nix/store/y0i8bbp5din1zb08hdk5lj9yrcfczzg0-google-compute-engine-20180510
/nix/store/6nzajmz5g67l8wv6f7jdgzmlqh6azisg-google-compute-engine-20180510
/nix/store/y0i8bbp5din1zb08hdk5lj9yrcfczzg0-google-compute-engine-20180510

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.google-compute-engine, python36Packages.google-compute-engine, google-compute-engine

Partial log (click to expand)

/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510/bin/set_multiqueue: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510...
wrapping `/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510/bin/google_network_daemon'...
wrapping `/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510/bin/google_metadata_script_runner'...
wrapping `/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510/bin/google_instance_setup'...
wrapping `/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510/bin/google_clock_skew_daemon'...
wrapping `/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510/bin/google_accounts_daemon'...
/nix/store/r8laj59r6331qgixm6zldkfay6i1plfc-google-compute-engine-20180510
/nix/store/wh3idmn0bj8r09qdar0mwg1p49ivsv21-google-compute-engine-20180510
/nix/store/r8laj59r6331qgixm6zldkfay6i1plfc-google-compute-engine-20180510

@xeji xeji merged commit baa7e52 into NixOS:master Sep 24, 2018
xeji pushed a commit that referenced this pull request Sep 24, 2018
@Ma27 @xeji
python3Packages.google-compute-engine: fix build (#47267)
32a5d08 
The dependency `distro` was missing.
See https://hydra.nixos.org/build/81330387

Addresses #45960

(cherry picked from commit baa7e52)
@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

backported: 32a5d08

@Ma27 Ma27 deleted the fix-google-cloud-engine branch September 24, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg