Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clightning: 0.6.0 -> 0.6.1 #47286

Merged
merged 1 commit into from Sep 25, 2018
Merged

clightning: 0.6.0 -> 0.6.1 #47286

merged 1 commit into from Sep 25, 2018

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Sep 24, 2018

Update to the latest release.

Highlights for c-lightning users

  • Less stuck payments: Liveness ping test before locking up funds with peers.
  • Better routing: now considers size of channels.
  • Fewer spurious closes: fee estimate improvements, and new feerates command
  • Several annoying bugs fixed.

Highlights for the network

  • Gossipd now less spammy with channel_update.
  • option_data_loss_protect to protect peers against being out-of-date.
  • Payment errors now refer to the correct channel.

Internal Improvements

  • Simplified client flow; after init message exchange by connectd, each is
    isolated in its own daemon.
  • JSON parameter handling vastly simplfied.
  • Python testing framework now uses proper fixtures, and split into separate
    files.
  • Many other cleanups and clarifications.
  • We keepachangelog.com!

Signed-off-by: William Casarin jb55@jb55.com

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @roconnor

@jb55
clightning: 0.6.0 -> 0.6.1
2aa0b85 
Update to the latest release.

Highlights for c-lightning users
--------------------------------

  - Less stuck payments: Liveness ping test before locking up funds with peers.
  - Better routing: now considers size of channels.
  - Fewer spurious closes: fee estimate improvements, and new feerates command
  - Several annoying bugs fixed.

Highlights for the network
--------------------------

  - Gossipd now less spammy with channel_update.
  - option_data_loss_protect to protect peers against being out-of-date.
  - Payment errors now refer to the correct channel.

Internal Improvements
---------------------

  - Simplified client flow; after init message exchange by connectd, each is
    isolated in its own daemon.
  - JSON parameter handling vastly simplfied.
  - Python testing framework now uses proper fixtures, and split into separate
    files.
  - Many other cleanups and clarifications.
  - We keepachangelog.com!

Signed-off-by: William Casarin <jb55@jb55.com>
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: clightning

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: clightning

Partial log (click to expand)

shrinking /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/libexec/c-lightning/lightning_closingd
shrinking /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/libexec/c-lightning/lightning_channeld
shrinking /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/bin/lightningd
shrinking /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/bin/lightning-cli
gzipping man pages under /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/libexec  /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1/bin
patching script interpreter paths in /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1
checking for references to /build in /nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1...
/nix/store/c7z1qm8bzxpji8jziipvc4fpyjl6z9qr-clightning-0.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: clightning

Partial log (click to expand)

shrinking /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/libexec/c-lightning/lightning_connectd
shrinking /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/libexec/c-lightning/lightning_gossipd
shrinking /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/bin/lightningd
shrinking /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/bin/lightning-cli
gzipping man pages under /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/libexec  /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1/bin
patching script interpreter paths in /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1
checking for references to /build in /nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1...
/nix/store/3vs62hd7n5qkmm14dmb4wqllvi9lal6c-clightning-0.6.1

@srhb srhb merged commit a27863c into NixOS:master Sep 25, 2018
srhb pushed a commit that referenced this pull request Sep 25, 2018
@jb55 @srhb
clightning: 0.6.0 -> 0.6.1
3b175f5 
Update to the latest release.

Highlights for c-lightning users
--------------------------------

  - Less stuck payments: Liveness ping test before locking up funds with peers.
  - Better routing: now considers size of channels.
  - Fewer spurious closes: fee estimate improvements, and new feerates command
  - Several annoying bugs fixed.

Highlights for the network
--------------------------

  - Gossipd now less spammy with channel_update.
  - option_data_loss_protect to protect peers against being out-of-date.
  - Payment errors now refer to the correct channel.

Internal Improvements
---------------------

  - Simplified client flow; after init message exchange by connectd, each is
    isolated in its own daemon.
  - JSON parameter handling vastly simplfied.
  - Python testing framework now uses proper fixtures, and split into separate
    files.
  - Many other cleanups and clarifications.
  - We keepachangelog.com!

Signed-off-by: William Casarin <jb55@jb55.com>

(cherry picked from commit 2aa0b85)
Backport of #47286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jb55 @GrahamcOfBorg @srhb