Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 35271fdb2fd3
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 570ec19f3910
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 24, 2018

  1. nixos/tests/installer: prevent race between parted and udev 

    by combining all parted commands into a single parted call.
This eliminates one cause of non-deterministic failure.

(cherry picked from commit a518376)
    @xeji
    xeji committed Sep 24, 2018
    Copy the full SHA
    dc74ab0 View commit details
    Browse the repository at this point in the history

  2. nixos/tests/installer: use flock for all parted calls 

    to further reduce risk of race with udev, like util-linux
recommends for sfdisk:
https://github.com/karelzak/util-linux/blob/v2.32/disk-utils/sfdisk.8#L71

(cherry picked from commit c46677f)
    @xeji
    xeji committed Sep 24, 2018
    Copy the full SHA
    c2ab695 View commit details
    Browse the repository at this point in the history

  3. nixos/tests/installer: stop udev queue before calling mdadm 

    In the swraid test, temporarily stop udev queue execution while
creating mdraid devices to prevent a race with udev, see
https://groups.google.com/forum/#!topic/scylladb-dev/u87yHgo3ylU

(cherry picked from commit 7dd6a51)
    @xeji
    xeji committed Sep 24, 2018
    Copy the full SHA
    570ec19 View commit details
    Browse the repository at this point in the history