Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compactor: 0.11.0 -> 0.11.1 #47271

Merged
merged 1 commit into from Sep 24, 2018
Merged

compactor: 0.11.0 -> 0.11.1 #47271

merged 1 commit into from Sep 24, 2018

Conversation

fdns
Copy link
Contributor

@fdns fdns commented Sep 24, 2018

Motivation for this change

Update compactor, adding compatibility with libtins 4.0 (required for #38208)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fdns fdns mentioned this pull request Sep 24, 2018
Merged
@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

@GrahamcOfBorg build compactor

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: compactor

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1
shrinking /nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1/bin/inspector
shrinking /nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1/bin/compactor
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1/bin
patching script interpreter paths in /nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1
checking for references to /build in /nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1...
/nix/store/fyh8nff7kf981vfqfnry1ha30k3b3rc8-compactor-0.11.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: compactor

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1
shrinking /nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1/bin/inspector
shrinking /nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1/bin/compactor
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1/bin
patching script interpreter paths in /nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1
checking for references to /build in /nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1...
/nix/store/rjjgy7hj1bks5712vzmw8film9f0nvyj-compactor-0.11.1

@xeji
Copy link
Contributor

xeji commented Sep 24, 2018

@GrahamcOfBorg eval

@xeji xeji merged commit 60909fd into NixOS:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fdns @Ekleog @GrahamcOfBorg @xeji