et-book: init at 1.0 #46471
Merged
et-book: init at 1.0 #46471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
requested changes
Sep 10, 2018
pkgs/data/fonts/et-book/default.nix
Outdated
| { stdenv, fetchFromGitHub }: | ||
|
|
||
| fetchFromGitHub rec { | ||
| rev = "1.0"; |
There was a problem hiding this comment.
Since upstream is not versioned, this should be 2018-09-10
There was a problem hiding this comment.
using the rev string instead, would that be okay?
pkgs/data/fonts/et-book/default.nix
Outdated
| fetchFromGitHub rec { | ||
| rev = "1.0"; | ||
| name = "et-book-${rev}"; | ||
| owner = "jethrokuan"; |
There was a problem hiding this comment.
I think this should point to original repository from edwardtufte https://github.com/edwardtufte/et-book/tree/gh-pages/source/4-ttf
There was a problem hiding this comment.
👍 my nix-fu wasn't strong enough when I packaged it then, let me know if there's a better way to package it now
|
@marsam anything else to change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ET Bembo is a relatively popular font, surprised to see it yet to be packaged in Nixpkgs. The revision given is bogus, this font has not been updated for many years.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)