Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe-money: Fix dependencies for safe-money-* #46479

Merged
merged 1 commit into from Sep 10, 2018
Merged

safe-money: Fix dependencies for safe-money-* #46479

merged 1 commit into from Sep 10, 2018

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Sep 10, 2018 •
edited

Motivation for this change

safe-money-* all depend on safe-money-0.7, but hackage2nix made them incorrectly
depend on safe-money-0.6. In safe-money-0.7 the safe-money package was split up
into multiple packages. This is why this occurred.

We should be able to remove this 'hack' as soon as the new Stackage LTS
comes out, as safe-money-0.7 will then be the default version.

fixes #46467
cc #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@arianvp
safe-money: Fix dependencies for safe-money-*
02feb90 
They all depend on safe-money-0.7, but hackage2nix made them incorrectly
depend on safe-money-0.6

We should be able to remove this 'hack' as soon as the new Stackage LTS
comes out, as safe-money-0.7 will then be the default version.
@arianvp
Copy link
Member Author

arianvp commented Sep 10, 2018

@GrahamcOfBorg build haskellPackages.safe-money-aeson haskellPackages.safe-money-store haskellPackages.safe-money-cereal haskellPackages.safe-money-serialise haskellPackages.safe-money-xmlbf

@flokli
Copy link
Contributor

flokli commented Sep 10, 2018

@GrahamcOfBorg build haskellPackages.safe-money-aeson haskellPackages.safe-money-store haskellPackages.safe-money-cereal haskellPackages.safe-money-serialise haskellPackages.safe-money-xmlbf

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.safe-money-aeson, haskellPackages.safe-money-store, haskellPackages.safe-money-cereal, haskellPackages.safe-money-serialise, haskellPackages.safe-money-xmlbf

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.safe-money-aeson, haskellPackages.safe-money-store, haskellPackages.safe-money-cereal, haskellPackages.safe-money-serialise, haskellPackages.safe-money-xmlbf

Partial log (click to expand)

strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8xc8z61swgl8bffw64gjykvs9k3wk8nr-safe-money-xmlbf-0.1/lib
patching script interpreter paths in /nix/store/8xc8z61swgl8bffw64gjykvs9k3wk8nr-safe-money-xmlbf-0.1
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/gw1xrg99fqzfbl3s35c0kx0xc6b2figc-safe-money-xmlbf-0.1-doc
/nix/store/5klfdkrpmjhdj0y2yh25rzyqdfsb9f6c-safe-money-aeson-0.1
/nix/store/5jsc2zbm0wki5033srbkdvpr5a0pihww-safe-money-store-0.1
/nix/store/jmglal32ynkd3bw5lz12x1p1b0dqqsy1-safe-money-cereal-0.1
/nix/store/ksirjjh719nnvbp10s73qd0q6yp9hj5q-safe-money-serialise-0.1
/nix/store/8xc8z61swgl8bffw64gjykvs9k3wk8nr-safe-money-xmlbf-0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.safe-money-aeson, haskellPackages.safe-money-store, haskellPackages.safe-money-cereal, haskellPackages.safe-money-serialise, haskellPackages.safe-money-xmlbf

Partial log (click to expand)

wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/ydrgb5l4r29w4p569270hmqr0biaaa85-safe-money-xmlbf-0.1-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ydrgb5l4r29w4p569270hmqr0biaaa85-safe-money-xmlbf-0.1-doc
checking for references to /build in /nix/store/ydrgb5l4r29w4p569270hmqr0biaaa85-safe-money-xmlbf-0.1-doc...
/nix/store/ybvajp2zq6d0sz9zzmfpjysxsn04854h-safe-money-aeson-0.1
/nix/store/rbvspk5ps4k3vwyq0cdjqdz0czmybz73-safe-money-store-0.1
/nix/store/jbxpivj021rqk8dh9hk0zp1iq0b0hv9j-safe-money-cereal-0.1
/nix/store/ky6475ydxr2314fswr1ib2s4p2ikajlp-safe-money-serialise-0.1
/nix/store/8phzvvb9kra1cv2dw0v0kvfkjx3zkjvf-safe-money-xmlbf-0.1

@Mic92 Mic92 merged commit e718721 into NixOS:master Sep 10, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 10, 2018 •
edited

backport:

[detached HEAD 23bbe26] safe-money: Fix dependencies for safe-money-*
Author: Arian van Putten aeroboy94@gmail.com
Date: Mon Sep 10 13:34:28 2018 +0200
1 file changed, 8 insertions(+)

@k0001
Copy link
Contributor

k0001 commented Sep 20, 2018

Thanks @arianvp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why was safe-money renamed to safe-money_0_7?
5 participants
@arianvp @flokli @GrahamcOfBorg @Mic92 @k0001