Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: unpin go version #46428

Merged
merged 1 commit into from Sep 10, 2018
Merged

dockerTools: unpin go version #46428

merged 1 commit into from Sep 10, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Sep 9, 2018 •
edited

The linked PR has been merged, and in fact dockerTools has upgraded to the
latest go1.11 compiler:

moby/moby#35739
moby/moby#37358

Motivation for this change

Simplifying the dependencies!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
dockerTools: unpin go version
4d8bb9a 
The linked PR has been merged, and in fact dockerTools has upgraded to the
latest `go1.11` compiler:

moby/moby#35739
moby/moby#37358
@bhipple
Copy link
Contributor Author

bhipple commented Sep 9, 2018

CC @adisbladis

@adisbladis
Copy link
Member

Great, thanks!

@adisbladis adisbladis merged commit cdce8f9 into NixOS:master Sep 10, 2018
@bhipple bhipple deleted the fix/dockerTools branch September 22, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @adisbladis @GrahamcOfBorg