Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.RPostgres: fix configure paths and includes #46445

Merged
merged 1 commit into from Sep 10, 2018
Merged

rPackages.RPostgres: fix configure paths and includes #46445

merged 1 commit into from Sep 10, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Sep 9, 2018

closes #46208

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ryantm ryantm requested a review from peti as a code owner September 9, 2018 21:38
@ivanbrennan
Copy link
Member

I can confirm this fixes #46208

@ryantm
Copy link
Member Author

ryantm commented Sep 10, 2018

@GrahamcOfBorg build rPackages.RPostgres

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rPackages.RPostgres

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rPackages.RPostgres

Partial log (click to expand)

** building package indices
** testing if installed package can be loaded
* DONE (RPostgres)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i2xyd70mlpnz0zz872nrig944wncw69p-r-RPostgres-1.1.1
shrinking /nix/store/i2xyd70mlpnz0zz872nrig944wncw69p-r-RPostgres-1.1.1/library/RPostgres/libs/RPostgres.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i2xyd70mlpnz0zz872nrig944wncw69p-r-RPostgres-1.1.1
checking for references to /build in /nix/store/i2xyd70mlpnz0zz872nrig944wncw69p-r-RPostgres-1.1.1...
/nix/store/i2xyd70mlpnz0zz872nrig944wncw69p-r-RPostgres-1.1.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rPackages.RPostgres

Partial log (click to expand)

** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded
* DONE (RPostgres)
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/kxclb1z5s9xrwc1jyq649zwyvgxqx7n3-r-RPostgres-1.1.1
/nix/store/kxclb1z5s9xrwc1jyq649zwyvgxqx7n3-r-RPostgres-1.1.1

@ryantm ryantm merged commit 8e991ac into NixOS:master Sep 10, 2018
@ryantm ryantm deleted the rpostgres branch September 10, 2018 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPostgres rPackage error
3 participants
@ryantm @ivanbrennan @GrahamcOfBorg