Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano: 2.9.8 -> 3.0 #46444

Merged
merged 1 commit into from Sep 10, 2018
Merged

nano: 2.9.8 -> 3.0 #46444

merged 1 commit into from Sep 10, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 9, 2018

Motivation for this change

Changelog: http://lists.gnu.org/archive/html/info-nano/2018-09/msg00000.html

Also updated the nix highlighting for nano

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jgeerds @joachifm

@etu
nano: 2.9.8 -> 3.0
b47c587 
Changelog: http://lists.gnu.org/archive/html/info-nano/2018-09/msg00000.html

Also updated the nix highlighting for nano
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nano

Partial log (click to expand)

shrinking /nix/store/qzxyx2ppkincbjd02ii8dsdzzhr62avl-nano-3.0/bin/nano
gzipping man pages under /nix/store/qzxyx2ppkincbjd02ii8dsdzzhr62avl-nano-3.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qzxyx2ppkincbjd02ii8dsdzzhr62avl-nano-3.0/bin
patching script interpreter paths in /nix/store/qzxyx2ppkincbjd02ii8dsdzzhr62avl-nano-3.0
checking for references to /build in /nix/store/qzxyx2ppkincbjd02ii8dsdzzhr62avl-nano-3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/16hlgzgk2bwhy2h1s2i3kcd7ilf9pgdq-nano-3.0-info
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/16hlgzgk2bwhy2h1s2i3kcd7ilf9pgdq-nano-3.0-info
checking for references to /build in /nix/store/16hlgzgk2bwhy2h1s2i3kcd7ilf9pgdq-nano-3.0-info...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nano

Partial log (click to expand)

shrinking /nix/store/01ndywlf2jlbjjjrzbc4h10jb9hzwvsp-nano-3.0/bin/nano
gzipping man pages under /nix/store/01ndywlf2jlbjjjrzbc4h10jb9hzwvsp-nano-3.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/01ndywlf2jlbjjjrzbc4h10jb9hzwvsp-nano-3.0/bin
patching script interpreter paths in /nix/store/01ndywlf2jlbjjjrzbc4h10jb9hzwvsp-nano-3.0
checking for references to /build in /nix/store/01ndywlf2jlbjjjrzbc4h10jb9hzwvsp-nano-3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/lq6k98gckchkj5rq8dhx902b9sy6cv4y-nano-3.0-info
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lq6k98gckchkj5rq8dhx902b9sy6cv4y-nano-3.0-info
checking for references to /build in /nix/store/lq6k98gckchkj5rq8dhx902b9sy6cv4y-nano-3.0-info...

@etu
Copy link
Contributor Author

etu commented Sep 9, 2018 •
edited

I'd say that this is worth backporting to 18.09 as well, since it's not released yet 🙂

@timokau timokau merged commit cb7c04f into NixOS:master Sep 10, 2018
@timokau
Copy link
Member

timokau commented Sep 10, 2018

Thanks! Why do you think this should be backported?

@etu etu deleted the upgrade-nano branch September 10, 2018 10:48
@etu
Copy link
Contributor Author

etu commented Sep 10, 2018

@timokau Well, normally it wouldn't. But since 18.09 isn't out yet it may be fine?

And I see one big reason, eventual big fixes for eventual problems with nano in the future will probably be made on the 3.x release series.

This is a guess though since I'm not involved with that project.

@timokau
Copy link
Member

timokau commented Sep 10, 2018

But since 18.09 isn't out yet it may be fine?

Well the reason we have a feature-freeze ~one month before release is to make sure everything that will be released is thouroughly tested. Regressions should be avoided, which is why I think we usually only include bug fixes and minor upgrades from that point. That is very important for libraries, however I think for end-user applications we can be a bit more lenient. Your argument is a good one.

@samueldr what do you think?

@samueldr
Copy link
Member

Looking at (an elided version of) ofborg's diff:

x86_64-linux    cabal2nix
x86_64-linux    crip
x86_64-linux    cvs
x86_64-linux    cvs2svn
x86_64-linux    cvs_fast_export
x86_64-linux    cvsps
x86_64-linux    nano
x86_64-linux    nix-prefetch-cvs
x86_64-linux    nix-prefetch-scripts
x86_64-linux    nix-update-source
x86_64-linux    reposurgeon
x86_64-linux    rssh
  • Haven't checked why cabal2nix has a nano dep.
  • crip replaces $editor = vim with a full path to nano (???)

CVS has nano as its buildInputs, explaining all of those other deps.

This looks like it won't be an issue backporting. Additionally, security and minor releases probably won't happen for versions earlier.

@timokau
Copy link
Member

timokau commented Sep 12, 2018

Alright, thanks for having a look at this. For reference: backported in 8468a4b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @GrahamcOfBorg @timokau @samueldr