New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spidermonkey_52: don't use jemalloc w/musl #46450
Conversation
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: spidermonkey_52 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: spidermonkey_52 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: spidermonkey_52 Partial log (click to expand)
|
Why do you want to disable jemalloc? |
Not so much don't want as it doesn't work so disable it instead of failing to build :). Historically musl wasn't compatible with malloc replacements, with 1.1.20 (days old) being first with support. The build failure didn't look too bad but since I'm not sure it would work anyway seemed best to disable it. |
Should this be backported? |
@dtzWill Since 1.1.20 is already merged, would you revert this if it is not necessary? (Actually older musls can be used with external allocators as long as they are built without the internal one.) |
Of course! Looking into it briefly I'm not optimistic about jemalloc-- having trouble getting the test-suite (for the jemalloc package itself, not the one vendored in mozjs) to not crash w/musl on versions 5.0.1 (our default), 5.1.0 (latest), or the current 'dev' branch code. That said, various musl-based distributions package it so maybe it's worth looking into further. FWIW the build failure was due to attempting to include 'sys/sysctl.h' which doesn't exist w/musl. |
Quick follow-up in terms of Nixpkgs and jemalloc+musl:
Where by jemalloc "working" I mean "jemalloc tests pass". |
I had used musl with jemalloc 3.6.0.
Edit: it does exist and is documented here, my |
Well it seems to exist in our glibc's include directory (in `glibc.dev`).
Dunno.
…On Mon, Sep 10, 2018 at 9:46 AM Orivej Desh ***@***.***> wrote:
I had used musl with jemalloc 3.6.0.
sys/sysctl.h seems to be a BSD header, it does not exist on Linux even
with Glibc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46450 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAx4sqE52ry6B7K7XFAPvgM4g8GmIsMWks5uZntZgaJpZM4Wgfnf>
.
|
😱 |
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)