Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxshmfence: 1.2 -> 1.3 fixes memfd_create usage w/musl #46451

Closed
wants to merge 1 commit into from
Closed

libxshmfence: 1.2 -> 1.3 fixes memfd_create usage w/musl #46451

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 9, 2018

I think needed for newer glibc versions as well, FWIW.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Sep 9, 2018

Errr @GrahamcOfBorg that can't be right, many things use libxshmfence ! :(

@xeji
Copy link
Contributor

xeji commented Sep 10, 2018

Don't be mad at the poor borg 😄
@GrahamcOfBorg build xorg.libxshmfence

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xorg.libxshmfence

Partial log (click to expand)

/nix/store/dhwmp45fw81h5dx21453mdb90zfqkqay-libxshmfence-1.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xorg.libxshmfence

Partial log (click to expand)

/nix/store/2kyhnl4q8993c65hdfnyxxwgl7fshqam-libxshmfence-1.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: xorg.libxshmfence

Partial log (click to expand)

these paths will be fetched (0.00 MiB download, 0.01 MiB unpacked):
  /nix/store/9ccj5b4ww765nckcamzj3vpmcbv2ykf1-libxshmfence-1.3
copying path '/nix/store/9ccj5b4ww765nckcamzj3vpmcbv2ykf1-libxshmfence-1.3' from 'https://cache.nixos.org'...
/nix/store/9ccj5b4ww765nckcamzj3vpmcbv2ykf1-libxshmfence-1.3

@xeji
Copy link
Contributor

xeji commented Sep 10, 2018

Simple explanation: We're already at 1.3:

nixpkgs/pkgs/servers/x11/xorg/overrides.nix

Line 269 in 868f256

name = "libxshmfence-1.3";

You edited the wrong file 😄

nixpkgs/pkgs/servers/x11/xorg/default.nix

Line 1 in 868f256

# THIS IS A GENERATED FILE. DO NOT EDIT!

@xeji xeji closed this Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @xeji @GrahamcOfBorg