→ #45960 will need this backported (leaving a note for myself).

@GrahamcOfBorg build openra gdata-sharp dotnetPackages.Paket dotnetPackages.FSharpAutoComplete

I have done local builds for openra, gdata-sharp, dotnetPackages.Paket and dotnetPackages.FSharpAutoComplete on 18.09. Of those, only openra built, but the failures are unrelated to this fix. Let's see what the CI sees. (99% sure this gets merged after it finishes building, then backported)

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openra, gdata-sharp, dotnetPackages.Paket, dotnetPackages.FSharpAutoComplete

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openra, gdata-sharp, dotnetPackages.Paket, dotnetPackages.FSharpAutoComplete

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Awesome, thanks. Note that this just avoids building the unit tests of Newtonsoft.Json. It's not ideal, but I couldn't find another way. I think it won't affect other packages though.

Oh, (I'm deferring to your knowledge)

@bobvanderlinden there was an aborted PR earlier, #44478, with commit c632384 upgrading this package. Any comments? If this works, and the test suite passes, and dependencies are happy, it may be better to upgrade?

EDIT: on 18.09, the same amount of success/breakage happens with that update, which imho is good (since the breakage on the other package is seemingly unrelated).

Failure on x86_64-linux (full log)

Attempted: openra, gdata-sharp, dotnetPackages.Paket, dotnetPackages.FSharpAutoComplete

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kpk9pmmxagqp7n7qxwr3nsmyb04dxmy0-openra-20180307
gzipping man pages under /nix/store/kpk9pmmxagqp7n7qxwr3nsmyb04dxmy0-openra-20180307/share/man/
patching script interpreter paths in /nix/store/kpk9pmmxagqp7n7qxwr3nsmyb04dxmy0-openra-20180307
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/kpk9pmmxagqp7n7qxwr3nsmyb04dxmy0-openra-20180307/lib/openra/.launch-game.sh-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/kpk9pmmxagqp7n7qxwr3nsmyb04dxmy0-openra-20180307/lib/openra/launch-dedicated.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/kpk9pmmxagqp7n7qxwr3nsmyb04dxmy0-openra-20180307...
error: build of '/nix/store/7alzda8pvyyigj4iggpy49lmhx552gz1-Paket-1.18.2.drv', '/nix/store/m5ixrpgimsz4jddip14qlnycf5hmq40r-gdata-sharp-2.2.0.0.drv', '/nix/store/msl5y9y0dw2lsyad7gbsfbha9ba0pvjq-FSharp.AutoComplete-0.18.2.drv' failed

I can confirm that OpenRA builds and works with c632384. 👍

This is related to getting all tests passing for 18.09: #45960

Maybe I wasn't clear enough, let me rephrase:

@bobvanderlinden what's your opinion on using c632384 instead of your PR? Do you see any downsides of upgrading? (I'd guess none, but you seem to be more knowledgeable with .NET stuff.)

Ah missed your comment. That seems like a better way to go if all packages indeed keep working. 👍

closing in favor of #46679