Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spl/zfs: 0.7.9 -> 0.7.10 #46426

Merged
merged 1 commit into from Sep 11, 2018
Merged

spl/zfs: 0.7.9 -> 0.7.10 #46426

merged 1 commit into from Sep 11, 2018

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Sep 9, 2018

Motivation for this change

0.7.10 is compatible with 4.18.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • nix-build -A stable zfs.nix
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@clefru
Copy link
Contributor Author

clefru commented Sep 9, 2018

@fpletz @Mic92 FYI

@fpletz
Copy link
Member

fpletz commented Sep 9, 2018

@GrahamcOfBorg build linuxPackages_latest.zfs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages_latest.zfs

Partial log (click to expand)

while evaluating the attribute 'linux_4_18' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14031:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14031:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.18.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14335:16, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.18.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:14335:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:51:1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxPackages_latest.zfs

Partial log (click to expand)

 /nix/store/ck0x3a6c5g3764cdsrds5h4bgy0xmfyp-coreutils-8.29/bin/install -c -m 644 zfs.release zfs_config.h module/Module.symvers '/nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6/zfs-0.7.10/4.18.6'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6/lib  /nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6/libexec
patching script interpreter paths in /nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6
checking for references to /build in /nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6...
/nix/store/8dahlhkzrxhcc79kgx0535yh823mhl77-zfs-kernel-0.7.10-4.18.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages_latest.zfs

Partial log (click to expand)

 /nix/store/wm8va53fh5158ipi0ic9gir64hrvqv1z-coreutils-8.29/bin/install -c -m 644 zfs.release zfs_config.h module/Module.symvers '/nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6/zfs-0.7.10/4.18.6'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6/lib  /nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6/libexec
patching script interpreter paths in /nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6
checking for references to /build in /nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6...
/nix/store/fkgjcic0xlbnfv0zm5h1pxyh4maybi9m-zfs-kernel-0.7.10-4.18.6

@Mic92 Mic92 added this to the 18.09 milestone Sep 9, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 9, 2018

Should be also backported.

@fpletz fpletz merged commit 13b7868 into NixOS:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
18.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clefru @fpletz @GrahamcOfBorg @Mic92