Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.joblib: Disable flaky test #46439

Merged
merged 1 commit into from Sep 9, 2018
Merged

pythonPackages.joblib: Disable flaky test #46439

merged 1 commit into from Sep 9, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should fix the darwin build of joblib.
Please backport to 18.09. (ZHF-darwin: #45961)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@knedlsepp
pythonPackages.joblib: Disable flaky test
472e388 
The test `test_nested_parallelism_limit` fails on darwin.
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

@GrahamcOfBorg build python27Packages.joblib python36Packages.joblib

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.joblib, python36Packages.joblib

Partial log (click to expand)

[DEBUG:MainProcess:Dummy-629] Interpreter shutting down. Waking up queue_manager_threads [(<Thread(QueueManagerThread, started daemon 123145362837504)>, <joblib.externals.loky.process_executor._ThreadWakeup instance at 0x109fdac20>)]
[DEBUG:MainProcess:QueueManagerThread] queue management thread shutting down
[DEBUG:MainProcess:QueueManagerThread] closing call_queue
[DEBUG:MainProcess:QueueManagerThread] telling queue thread to quit
[DEBUG:MainProcess:QueueManagerThread] joining processes
[DEBUG:MainProcess:QueueFeederThread] feeder thread got sentinel -- exiting
[DEBUG:MainProcess:QueueManagerThread] queue management thread clean shutdown of worker processes: []
[DEBUG:MainProcess:Dummy-629] running the remaining "atexit" finalizers
/nix/store/5a6r5ky4pgp6vjr8g348q788z51m2rg7-python2.7-joblib-0.12.3
/nix/store/w57vwlcn1jf51wacig5h0qmbqlp7zgzp-python3.6-joblib-0.12.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.joblib, python36Packages.joblib

Partial log (click to expand)

[DEBUG:MainProcess:MainThread] Interpreter shutting down. Waking up queue_manager_threads [(<Thread(QueueManagerThread, started daemon 140737211713280)>, <joblib.externals.loky.process_executor._ThreadWakeup object at 0x7fffedeb92b0>)]
[DEBUG:MainProcess:QueueManagerThread] queue management thread shutting down
[DEBUG:MainProcess:QueueManagerThread] closing call_queue
[DEBUG:MainProcess:QueueManagerThread] telling queue thread to quit
[DEBUG:MainProcess:QueueManagerThread] joining processes
[DEBUG:MainProcess:QueueFeederThread] feeder thread got sentinel -- exiting
[DEBUG:MainProcess:QueueManagerThread] queue management thread clean shutdown of worker processes: []
[DEBUG:MainProcess:MainThread] running the remaining "atexit" finalizers
/nix/store/v942qi4agqr17pvvrli0dszvykw077kv-python2.7-joblib-0.12.3
/nix/store/0xycb7bshdknckg2n1p2wv7rylxwp9l2-python3.6-joblib-0.12.3

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: python27Packages.joblib, python36Packages.joblib

Partial log (click to expand)

[DEBUG:MainProcess:QueueManagerThread] queue management thread shutting down
[DEBUG:MainProcess:QueueManagerThread] closing call_queue
[DEBUG:MainProcess:QueueManagerThread] telling queue thread to quit
[DEBUG:MainProcess:QueueManagerThread] joining processes
[DEBUG:MainProcess:QueueFeederThread] feeder thread got sentinel -- exiting
[DEBUG:MainProcess:QueueManagerThread] queue management thread clean shutdown of worker processes: []
[DEBUG:MainProcess:MainThread] running the remaining "atexit" finalizers
builder for '/nix/store/l5ahhln95v2r8axj200f293dcyh0x2cz-python3.6-joblib-0.12.3.drv' failed with exit code 1
building of '/nix/store/nr7zbg01303fn5av06a3q5fja1ip5cw7-python2.7-joblib-0.12.3.drv' timed out after 3600 seconds
error: build of '/nix/store/l5ahhln95v2r8axj200f293dcyh0x2cz-python3.6-joblib-0.12.3.drv', '/nix/store/nr7zbg01303fn5av06a3q5fja1ip5cw7-python2.7-joblib-0.12.3.drv' failed

@xeji xeji merged commit 6f891ff into NixOS:master Sep 9, 2018
xeji pushed a commit that referenced this pull request Sep 9, 2018
@knedlsepp @xeji
pythonPackages.joblib: Disable flaky test (#46439)
9cb6025 
The test `test_nested_parallelism_limit` fails on darwin.

(cherry picked from commit 6f891ff)
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

backported: 9cb6025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @xeji @GrahamcOfBorg