Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask_ldap_login: Fix build #46438

Merged
merged 3 commits into from Sep 9, 2018
Merged

pythonPackages.flask_ldap_login: Fix build #46438

merged 3 commits into from Sep 9, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

flask_ldap_login does currently not our version of flask_wtf.
There is however already a PR upstream to fix the issue, which we can use as a patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

cc ZHF #45960
@GrahamcOfBorg build python36Packages.flask_ldap_login python27Packages.flask_ldap_login

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python36Packages.flask_ldap_login, python27Packages.flask_ldap_login

Partial log (click to expand)

-------------------- >> begin captured logging << --------------------
flask_ldap_login: DEBUG: Connecting to ldap server ldap://127.0.0.1
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 6 tests in 0.280s

FAILED (errors=5)
builder for '/nix/store/jfpzi8dfp3vzff3p9y3vij60x8bkfjji-python3.6-flask-ldap-login-0.3.4.drv' failed with exit code 1
error: build of '/nix/store/jfpzi8dfp3vzff3p9y3vij60x8bkfjji-python3.6-flask-ldap-login-0.3.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python36Packages.flask_ldap_login, python27Packages.flask_ldap_login

Partial log (click to expand)

-------------------- >> begin captured logging << --------------------
flask_ldap_login: DEBUG: Connecting to ldap server ldap://127.0.0.1
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 6 tests in 1.213s

FAILED (errors=5)
builder for '/nix/store/i91hn4bjzj8nnjiwkdf9pvb4vma1kww0-python3.6-flask-ldap-login-0.3.4.drv' failed with exit code 1
error: build of '/nix/store/i91hn4bjzj8nnjiwkdf9pvb4vma1kww0-python3.6-flask-ldap-login-0.3.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python36Packages.flask_ldap_login, python27Packages.flask_ldap_login

Partial log (click to expand)

-------------------- >> begin captured logging << --------------------
flask_ldap_login: DEBUG: Connecting to ldap server ldap://127.0.0.1
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 6 tests in 0.826s

FAILED (errors=5)
builder for '/nix/store/zwb1k521glqkzwbi1g698xsb9pvqvqp8-python3.6-flask-ldap-login-0.3.4.drv' failed with exit code 1
error: build of '/nix/store/zwb1k521glqkzwbi1g698xsb9pvqvqp8-python3.6-flask-ldap-login-0.3.4.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

the tests seem to use networking, fails in a sandbox. probably need to disable them.

@knedlsepp
Copy link
Member Author

knedlsepp commented Sep 9, 2018 •
edited

I could reproduce the error for python36Packages.flask_ldap_login even without sandboxing. The library is unsupported on python3. I added a commit to disable it.
@GrahamcOfBorg build python27Packages.flask_ldap_login

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.flask_ldap_login

Partial log (click to expand)

/nix/store/6p4gvlvin9iay08w1wshgg069r59dn6v-python2.7-flask-ldap-login-0.3.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.flask_ldap_login

Partial log (click to expand)

/build/source/flask_ldap_login/tests/test_login_form.py:32: FlaskWTFDeprecationWarning: "csrf_enabled" is deprecated and will be removed in 1.0. Set "meta.csrf" instead.
  form = LDAPLoginForm(flask.request.form, csrf_enabled=False)
./build/source/flask_ldap_login/tests/test_login_form.py:43: FlaskWTFDeprecationWarning: "csrf_enabled" is deprecated and will be removed in 1.0. Set "meta.csrf" instead.
  form = LDAPLoginForm(flask.request.form, csrf_enabled=False)
.....
----------------------------------------------------------------------
Ran 6 tests in 0.506s

OK
/nix/store/rhzkphs676cn5g32jyf0pjha2v5vkkxl-python2.7-flask-ldap-login-0.3.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.flask_ldap_login

Partial log (click to expand)

/nix/store/h9h2vqiqf751rldgr1mp7zyp90y95939-python2.7-flask-ldap-login-0.3.4

@xeji xeji merged commit d18aace into NixOS:master Sep 9, 2018
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

backported: 34059be..ff81358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @xeji @GrahamcOfBorg