Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentracker: 2016-10-02 -> 2018-05-26 #46437

Merged
merged 2 commits into from Sep 10, 2018
Merged

opentracker: 2016-10-02 -> 2018-05-26 #46437

merged 2 commits into from Sep 10, 2018

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Sep 9, 2018 •
edited

Motivation for this change

Opentracker version was lacking behind.

Also bittorrent test where this was used was failing. This PR doesn't fix the test though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 10, 2018
View reviewed changes
pkgs/applications/networking/p2p/opentracker/default.nix Outdated
@@ -1,12 +1,12 @@
{ stdenv, fetchgit, libowfat, zlib }:

stdenv.mkDerivation {
name = "opentracker-2016-10-02";
name = "opentracker-2018-05-26";

src = fetchgit {
url = "git://erdgeist.org/opentracker";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https seems appropriate: https://erdgeist.org/gitweb/opentracker

@bobvanderlinden
Copy link
Member Author

I can make a separate PR for that if you'd like as this is unrelated to the change I was intending.

Why would https be better than ssh?

@Mic92
Copy link
Member

Mic92 commented Sep 10, 2018

git:// is very different from ssh://. It is a plain text protocol designed for git. In nixpkgs we prefer https over the git protocol, because many users rely on trust-on-first-use to get the initial checksum and https also works fine behind cooperate proxies.

@Mic92
Copy link
Member

Mic92 commented Sep 10, 2018

@GrahamcOfBorg build opentracker

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: opentracker

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opentracker

Partial log (click to expand)

gcc -o opentracker.debug opentracker.debug.o trackerlogic.debug.o scan_urlencoded_query.debug.o ot_mutex.debug.o ot_stats.debug.o ot_vector.debug.o ot_clean.debug.o ot_udp.debug.o ot_iovec.debug.o ot_fullscrape.debug.o ot_accesslist.debug.o ot_http.debug.o ot_livesync.debug.o ot_rijndael.debug.o -L../libowfat -lowfat -pthread -lpthread -lz
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jjdqy80xh54giildln2l9bbsq2vgvz3h-opentracker-2018-05-26
shrinking /nix/store/jjdqy80xh54giildln2l9bbsq2vgvz3h-opentracker-2018-05-26/bin/opentracker
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jjdqy80xh54giildln2l9bbsq2vgvz3h-opentracker-2018-05-26/bin
patching script interpreter paths in /nix/store/jjdqy80xh54giildln2l9bbsq2vgvz3h-opentracker-2018-05-26
checking for references to /build in /nix/store/jjdqy80xh54giildln2l9bbsq2vgvz3h-opentracker-2018-05-26...
/nix/store/jjdqy80xh54giildln2l9bbsq2vgvz3h-opentracker-2018-05-26

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opentracker

Partial log (click to expand)

gcc -o opentracker.debug opentracker.debug.o trackerlogic.debug.o scan_urlencoded_query.debug.o ot_mutex.debug.o ot_stats.debug.o ot_vector.debug.o ot_clean.debug.o ot_udp.debug.o ot_iovec.debug.o ot_fullscrape.debug.o ot_accesslist.debug.o ot_http.debug.o ot_livesync.debug.o ot_rijndael.debug.o -L../libowfat -lowfat -pthread -lpthread -lz
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mic2qfq5mhk3b0zihjkbr313hqy6iin5-opentracker-2018-05-26
shrinking /nix/store/mic2qfq5mhk3b0zihjkbr313hqy6iin5-opentracker-2018-05-26/bin/opentracker
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mic2qfq5mhk3b0zihjkbr313hqy6iin5-opentracker-2018-05-26/bin
patching script interpreter paths in /nix/store/mic2qfq5mhk3b0zihjkbr313hqy6iin5-opentracker-2018-05-26
checking for references to /build in /nix/store/mic2qfq5mhk3b0zihjkbr313hqy6iin5-opentracker-2018-05-26...
/nix/store/mic2qfq5mhk3b0zihjkbr313hqy6iin5-opentracker-2018-05-26

@Mic92 Mic92 merged commit 107448f into NixOS:master Sep 10, 2018
@bobvanderlinden bobvanderlinden deleted the pr-opentracker-2018-05-26 branch September 12, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @Mic92 @GrahamcOfBorg