Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fiona: Fix darwin build #46435

Merged
merged 1 commit into from Sep 9, 2018
Merged

pythonPackages.fiona: Fix darwin build #46435

merged 1 commit into from Sep 9, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes the darwin build of pythonPackages.fiona.
Please backport to 18.09: #45961

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

@GrahamcOfBorg build python27Packages.fiona python36Packages.fiona

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.fiona, python36Packages.fiona

Partial log (click to expand)

  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed Fiona-1.7.13
/private/tmp/nix-build-python3.6-Fiona-1.7.13.drv-0/Fiona-1.7.13
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/07wxgzns4p8q063w7pa101a29gnkgvz9-python3.6-Fiona-1.7.13/lib  /nix/store/07wxgzns4p8q063w7pa101a29gnkgvz9-python3.6-Fiona-1.7.13/bin
patching script interpreter paths in /nix/store/07wxgzns4p8q063w7pa101a29gnkgvz9-python3.6-Fiona-1.7.13
wrapping `/nix/store/07wxgzns4p8q063w7pa101a29gnkgvz9-python3.6-Fiona-1.7.13/bin/fio'...
/nix/store/37rhgngxmpg6r703rlyz3mr2pr6n5ygr-python2.7-Fiona-1.7.13
/nix/store/07wxgzns4p8q063w7pa101a29gnkgvz9-python3.6-Fiona-1.7.13

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.fiona, python36Packages.fiona

Partial log (click to expand)

shrinking /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13/lib/python3.6/site-packages/fiona/_transform.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13/lib/python3.6/site-packages/fiona/_err.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13/lib/python3.6/site-packages/fiona/_geometry.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13/lib  /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13/bin
patching script interpreter paths in /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13
checking for references to /build in /nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13...
wrapping `/nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13/bin/fio'...
/nix/store/n3v1k5hkj313wz3s7s9gcvscyamn8vrw-python2.7-Fiona-1.7.13
/nix/store/1m87mmlrwk3yk6qdwv1jx9p0fhc7fhr2-python3.6-Fiona-1.7.13

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: python27Packages.fiona, python36Packages.fiona

Partial log (click to expand)

     HDFLIBAPI int32 HCPread
               ^~~~~
/build/hdf-4.2.14/hdf/src/tbbt.h:255:11: error: unknown type name 'VOIDP'
 HDFLIBAPI VOIDP       tbbtrem
           ^~~~~
building of '/nix/store/k2n0n7sfk1cz5qjj80adqx82sr67frm3-hdf-4.2.14.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/6crj09pvjs4qlmaki552jwq2xb86z5jh-gdal-2.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mdjgfvxp68r4niqyl9yiw85x5g2bwn2y-python2.7-Fiona-1.7.13.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f184q70x1mqrrck66i56wl4r97y78qc0-python3.6-Fiona-1.7.13.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f184q70x1mqrrck66i56wl4r97y78qc0-python3.6-Fiona-1.7.13.drv', '/nix/store/mdjgfvxp68r4niqyl9yiw85x5g2bwn2y-python2.7-Fiona-1.7.13.drv' failed

@xeji xeji merged commit 5e0c468 into NixOS:master Sep 9, 2018
xeji pushed a commit that referenced this pull request Sep 9, 2018
@knedlsepp @xeji
pythonPackages.fiona: Fix darwin build (#46435)
3143d6b 
(cherry picked from commit 5e0c468)
@xeji
Copy link
Contributor

xeji commented Sep 9, 2018

backported: 3143d6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @xeji @GrahamcOfBorg