Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lizardfs: init module #46446

Closed
wants to merge 1 commit into from
Closed

nixos/lizardfs: init module #46446

wants to merge 1 commit into from

Conversation

kliu128
Copy link

@kliu128 kliu128 commented Sep 9, 2018

Motivation for this change

LizardFS is packaged in NixOS, but there isn't a simple way to configure it, e.g. with chunkservers.

Things done
  • Allows running multiple chunkservers on one machine
  • CGI server, master server, and metaloggers supported
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kliu128
Copy link
Author

kliu128 commented Nov 22, 2018

Just updated it to change the mfs user/group ID to accomodate new users added in Nixpkgs. Could someone review?

@markuskowa
Copy link
Member

Would you mind adding a NixOS test?

@markuskowa markuskowa self-assigned this Nov 22, 2018
@kliu128
Copy link
Author

kliu128 commented Nov 22, 2018

Sure! I've never written one before, so this is my first time. I'll get back to you ;)

@markuskowa
Copy link
Member

Thanks! Take a look at nixos/tests/nfs.nix or nixos/tests/beegfs.nix as a starting point.

@ivan
Copy link
Member

ivan commented Sep 6, 2019

For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated types.string, which emits a warning as of #66346. Before merging, please change this to another type, possibly:

  • types.str for a single string where merging does not make sense, or cannot work
  • types.lines for multi-line configuration or scripts where merging is possible
  • types.listOf types.str for a mergeable list of strings

@infinisil
Copy link
Member

Closing since there doesn't seem to be much interest

@infinisil infinisil closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees

@markuskowa markuskowa

Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kliu128 @markuskowa @ivan @infinisil @ryantm @GrahamcOfBorg