Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version references to 7.1.0 #765

Merged
merged 2 commits into from Sep 20, 2018
Merged

Update version references to 7.1.0 #765

merged 2 commits into from Sep 20, 2018

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 9, 2018

Updated all references in the docs from 7.0.0 to 7.1.0.

The following entries refer to a pre release version of the API 7.1.0.
I'm not sure whether these files need to be updated.

  • /source/files/logs/SpongeForge_1.12.2-2705-7.1.0-BETA-3136_debug.log.txt
  • /source/files/logs/SpongeForge_1.12.2-2705-7.1.0-BETA-3136_latest.log.txt
  • /source/files/logs/SpongeVanilla_1.12.2-7.1.0-BETA-54_latest.log.txt

@ST-DDT ST-DDT added needs review The submission is ready and needs to be reviewed high priority This needs to be fixed ASAP labels Sep 9, 2018
Copy link
Member

@Inscrutable Inscrutable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That covers all the bases. For many of the these pages we only use the SpongeAPI version as an example anyway, so updating is just an optional courtesy. I presume we won't have to change the "stable-7" URLs on implementation/mixins, plugin/commands/arguments and plugin/debugging until we get to API 8.

Copy link
Contributor

@12awsomeman34 12awsomeman34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do question whether we need those above mentioned pages on the docs? Regardless it may be worth updating them to see if anything has changed.

@Inscrutable
Copy link
Member

The log pages are unnecessary, being only a courtesy. Updating them constantly may not be worth the effort, so if they fall by the way-side I won't complain. It might be better to feature in a separate PR though, as others may have different opinions.

@Inscrutable Inscrutable removed the needs review The submission is ready and needs to be reviewed label Sep 20, 2018
@Inscrutable Inscrutable merged commit 86001c3 into stable Sep 20, 2018
@ST-DDT ST-DDT deleted the update/api-7.1.0 branch September 20, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority This needs to be fixed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants