Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pango: 1.42.1 → 1.42.4 #45764

Merged
merged 1 commit into from
Aug 30, 2018
Merged

pango: 1.42.1 → 1.42.4 #45764

merged 1 commit into from
Aug 30, 2018
+25 −17

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 29, 2018 •
edited
Loading

Motivation for this change

Fixes a horrendous bug that crashes IRC clients, text editors, terminal emulators that receive invalid Unicode sequence.

Also ported to meson since autotools support has been removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jtojnar jtojnar added 0.kind: bug Something is broken 1.severity: security Issues which raise a security issue, or PRs that fix one labels Aug 29, 2018
@jtojnar jtojnar requested a review from vcunat August 29, 2018 19:49
@jtojnar
Copy link
Member Author

jtojnar commented Aug 29, 2018

To reproduce, open this file in something that renders text using pango (e.g. pango-view/less in gnome-terminal/Sublime Text). It will crash the program.

@samueldr samueldr added the 1.severity: blocker This is preventing another PR or issue from being completed label Aug 29, 2018
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@jtojnar
pango: 1.42.1 → 1.42.4

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
f9943cd 
Fixes a horrendous bug that crashes IRC clients, text editors, terminal
emulators that receive invalid Unicode sequence.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pango

Partial log (click to expand)

shrinking /nix/store/m7pb3bv6mizfhn4pi91h0zx1h82gfz31-pango-1.42.4/lib/libpangoxft-1.0.so.0.4200.4
shrinking /nix/store/m7pb3bv6mizfhn4pi91h0zx1h82gfz31-pango-1.42.4/lib/libpangocairo-1.0.so.0.4200.4
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m7pb3bv6mizfhn4pi91h0zx1h82gfz31-pango-1.42.4/lib
patching script interpreter paths in /nix/store/m7pb3bv6mizfhn4pi91h0zx1h82gfz31-pango-1.42.4
checking for references to /build in /nix/store/m7pb3bv6mizfhn4pi91h0zx1h82gfz31-pango-1.42.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/954y4832l28av2mmwyy91nffcgb8lfg7-pango-1.42.4-devdoc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/954y4832l28av2mmwyy91nffcgb8lfg7-pango-1.42.4-devdoc
checking for references to /build in /nix/store/954y4832l28av2mmwyy91nffcgb8lfg7-pango-1.42.4-devdoc...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pango

Partial log (click to expand)

/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpangocairo-1.0.0.dylib: fixing dylib
/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpangoft2-1.0.0.dylib: fixing dylib
/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpangoxft-1.0.0.dylib: fixing dylib
/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpango-1.0.0.dylib: fixing dylib
/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpangocairo-1.0.0.dylib: fixing dylib
/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpangoft2-1.0.0.dylib: fixing dylib
/nix/store/snq94p7sa9vm9c67g3km9n1wphwav8h1-pango-1.42.4/lib/libpangoxft-1.0.0.dylib: fixing dylib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/4m89ipjxp0jshdvvz9pnfs6c21va5zh9-pango-1.42.4-devdoc
/nix/store/8jmsa3s7wmdfzx4kk2a15rmy7qjsbv7k-pango-1.42.4-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pango

Partial log (click to expand)

shrinking /nix/store/fpignlm7cxnqnx52vzvlfbvmdwx16nn0-pango-1.42.4/lib/libpango-1.0.so.0.4200.4
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fpignlm7cxnqnx52vzvlfbvmdwx16nn0-pango-1.42.4/lib
patching script interpreter paths in /nix/store/fpignlm7cxnqnx52vzvlfbvmdwx16nn0-pango-1.42.4
checking for references to /build in /nix/store/fpignlm7cxnqnx52vzvlfbvmdwx16nn0-pango-1.42.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/j5d33jdzpf8hxi4nw53b0zzzw10qg9c1-pango-1.42.4-devdoc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/j5d33jdzpf8hxi4nw53b0zzzw10qg9c1-pango-1.42.4-devdoc
checking for references to /build in /nix/store/j5d33jdzpf8hxi4nw53b0zzzw10qg9c1-pango-1.42.4-devdoc...
/nix/store/4sp8l9awjvb766l0dg6xrvhhcqacc4a1-pango-1.42.4-bin

@jtojnar
Copy link
Member Author

jtojnar commented Aug 29, 2018

There seems to be a meson bug preventing GIR generation on Darwin. Fortunately, this is the last release that still supports autotools.

@vcunat vcunat changed the base branch from master to staging August 30, 2018 07:34
vcunat
vcunat approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK, including NEWS.

The fontconfig change is probably useless until the rest of doCheck is fixed, but why not keep it...

@vcunat vcunat merged commit f9943cd into NixOS:staging Aug 30, 2018
vcunat added a commit that referenced this pull request Aug 30, 2018
@vcunat
Merge #45764: pango: 1.42.1 → 1.42.4

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
d28ce15
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pango

Partial log (click to expand)

copying path '/nix/store/s82b9b9mm7lhx2sr3w9rcd6r1yxl5ncl-libglvnd-1.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/2idm98znj1fslr772sba8bpxp553gxfb-libXft-2.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/l8sxf74qnrs3w0vc5hk6iviza2n49ylb-pixman-0.34.0' from 'https://cache.nixos.org'...
copying path '/nix/store/8gd9mslrhrmim2zf23s6jxhh9bsbxp4f-util-linux-2.32.1' from 'https://cache.nixos.org'...
copying path '/nix/store/wgki8qb0h5q963pm890i0i3kpf15mmd8-glib-2.56.0' from 'https://cache.nixos.org'...
copying path '/nix/store/f0qbk34q6nhj4carlhxv7n4x81fd2b04-cairo-1.15.12' from 'https://cache.nixos.org'...
copying path '/nix/store/fnrxzg72aq4rra2xgx1d4chkkg7z3p0f-harfbuzz-1.8.8' from 'https://cache.nixos.org'...
copying path '/nix/store/gj69p82r07jkhp63z69c0xdwwmyxd143-pango-1.42.4' from 'https://cache.nixos.org'...
copying path '/nix/store/nml17fvz7dqf7x471b0a23b9znx3hf7m-pango-1.42.4-bin' from 'https://cache.nixos.org'...
/nix/store/nml17fvz7dqf7x471b0a23b9znx3hf7m-pango-1.42.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pango

Partial log (click to expand)

/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpangocairo-1.0.0.dylib: fixing dylib
/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpangoft2-1.0.0.dylib: fixing dylib
/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpangoxft-1.0.0.dylib: fixing dylib
/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpango-1.0.0.dylib: fixing dylib
/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpangocairo-1.0.0.dylib: fixing dylib
/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpangoft2-1.0.0.dylib: fixing dylib
/nix/store/lhvqpk3ikws6hqc5gyk6c39di88q1y8k-pango-1.42.4/lib/libpangoxft-1.0.0.dylib: fixing dylib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/arsa6br79xzp0ylangsmb26cl2q7xk77-pango-1.42.4-devdoc
/nix/store/76546mw3v9sb7bidy4gpmxbcmk5kfzkf-pango-1.42.4-bin

@jtojnar jtojnar deleted the pango-crash branch August 30, 2018 07:52
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pango

Partial log (click to expand)

shrinking /nix/store/sbfqdhg3fnfslpc2h23dcc92mlas6w2n-pango-1.42.4/lib/libpango-1.0.so.0.4200.4
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sbfqdhg3fnfslpc2h23dcc92mlas6w2n-pango-1.42.4/lib
patching script interpreter paths in /nix/store/sbfqdhg3fnfslpc2h23dcc92mlas6w2n-pango-1.42.4
checking for references to /build in /nix/store/sbfqdhg3fnfslpc2h23dcc92mlas6w2n-pango-1.42.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/plm5vrja1xzk2ya3cmcv8qdk13w41mby-pango-1.42.4-devdoc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/plm5vrja1xzk2ya3cmcv8qdk13w41mby-pango-1.42.4-devdoc
checking for references to /build in /nix/store/plm5vrja1xzk2ya3cmcv8qdk13w41mby-pango-1.42.4-devdoc...
/nix/store/5k5fgl3zc3sryj6c3bjwfijf10n493cb-pango-1.42.4-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
0.kind: bug Something is broken 1.severity: blocker This is preventing another PR or issue from being completed 1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @GrahamcOfBorg @vcunat @samueldr