Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcov: 35 -> 36 #45755

Merged
merged 1 commit into from Aug 29, 2018
Merged

kcov: 35 -> 36 #45755

merged 1 commit into from Aug 29, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Aug 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kcov

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36
shrinking /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36/bin/kcov-system-daemon
shrinking /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36/bin/kcov
gzipping man pages under /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36/bin
patching script interpreter paths in /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36
checking for references to /build in /nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36...
/nix/store/f1v7v4g9dp9wdmv6n40gcd413m44rajj-kcov-36

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kcov

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36
shrinking /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36/bin/kcov-system-daemon
shrinking /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36/bin/kcov
gzipping man pages under /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36/bin
patching script interpreter paths in /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36
checking for references to /build in /nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36...
/nix/store/f7bc87f53ki8w7pj2qp3xfy34hazvq2q-kcov-36

@Mic92 Mic92 merged commit d6305a5 into NixOS:master Aug 29, 2018
@Mic92
Copy link
Member

Mic92 commented Aug 29, 2018

Don't do sudo kcov --pid=1 /tmp/kcov btw :)

@Ekleog
Copy link
Member Author

Ekleog commented Aug 29, 2018

Thank you for the quick merge! :) Though now I'm curious, what happened to you with sudo kcov --pid=1 /tmp/kcov? 😅

@Mic92
Copy link
Member

Mic92 commented Aug 29, 2018

my kernel reported something like recursive fault fixed, but rebooting required and systemd rebooted.

@Ekleog
Copy link
Member Author

Ekleog commented Aug 30, 2018

Oh wow.

@Ekleog Ekleog deleted the kcov-36 branch August 30, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @Mic92