Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/i3wm: prevent non-deterministic failure #45759

Merged
merged 1 commit into from Aug 29, 2018
Merged

nixos/tests/i3wm: prevent non-deterministic failure #45759

merged 1 commit into from Aug 29, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Aug 29, 2018

Motivation for this change

Test failed sporadically on Hydra, probably due to timing issues according to the logs.
These changes should make that less likely to occur.

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/i3wm: prevent non-deterministic failure
28fc4ac 
Test failed sporadically on Hydra, probably due to timing issues.
These changes should make that less likely to occur.
@xeji
Copy link
Contributor Author

xeji commented Aug 29, 2018

@GrahamcOfBorg test i3wm

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.i3wm

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 28.69s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/36h1mwpmh21aj6wa8sy9pv9mlk2h1kn6-vm-test-run-i3wm

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.i3wm

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 52.14s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/9m81lwhxs2i1r9kdwvcslwr6k74mj122-vm-test-run-i3wm

@xeji xeji merged commit 70b3ac8 into NixOS:master Aug 29, 2018
@xeji xeji deleted the p/i3wm-test branch August 29, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg