pythonefl: 1.20.0 -> 1.21.0 #45668
pythonefl: 1.20.0 -> 1.21.0 #45668
Conversation
pkgs/top-level/python-packages.nix
Outdated
| @@ -15649,10 +15649,10 @@ EOF | |||
| # Should be bumped along with EFL! | |||
| pythonefl = buildPythonPackage rec { | |||
There was a problem hiding this comment.
We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.
Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.
There was a problem hiding this comment.
@FRidh a bot for this message would be nice :)
| maintainers = with maintainers; [ matejc tstrobel ftrvxmtrx ]; | ||
| }; | ||
| }; | ||
| pythonefl = callPackage ../development/python-modules/python-efl { }; |
There was a problem hiding this comment.
You forgot to add the file itself.
There was a problem hiding this comment.
In fact. Added it now.
- Move out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/python-efl/default.nix. - Add dependency on dbus-python. - Remove hardeningDisable. - Update some meta attributes.
| export NIX_CFLAGS_COMPILE="$(pkg-config --cflags efl) -I${python.pkgs.dbus-python}/include/dbus-1.0 $NIX_CFLAGS_COMPILE" | ||
| ''; | ||
|
|
||
| preBuild = "${python}/bin/${python.executable} setup.py build_ext"; |
|
|
||
| preBuild = "${python}/bin/${python.executable} setup.py build_ext"; | ||
|
|
||
| installPhase= "${python}/bin/${python.executable} setup.py install --prefix=$out"; |
There was a problem hiding this comment.
Is this phase not the default?
I do not think so, because without it most of the files are not installed. It was already present in prior versions of the nix expression.
Motivation for this change
Update to version 1.21.0
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)