Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vitetris: init at 0.57.2 #45672

Merged
merged 1 commit into from Aug 27, 2018
Merged

vitetris: init at 0.57.2 #45672

merged 1 commit into from Aug 27, 2018

Conversation

siers
Copy link
Member

@siers siers commented Aug 27, 2018

Motivation for this change

I need more tetris in my life and so should you.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

@GrahamcOfBorg build vitetris

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vitetris

Partial log (click to expand)

You may also wish to create the system-wide highscore file
with "make install-hiscores".
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d5zxjvsgrdrhfnsrzzf0ln0862f7xmvl-vitetris-0.57.2
shrinking /nix/store/d5zxjvsgrdrhfnsrzzf0ln0862f7xmvl-vitetris-0.57.2/bin/tetris
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d5zxjvsgrdrhfnsrzzf0ln0862f7xmvl-vitetris-0.57.2/bin
patching script interpreter paths in /nix/store/d5zxjvsgrdrhfnsrzzf0ln0862f7xmvl-vitetris-0.57.2
checking for references to /build in /nix/store/d5zxjvsgrdrhfnsrzzf0ln0862f7xmvl-vitetris-0.57.2...
/nix/store/d5zxjvsgrdrhfnsrzzf0ln0862f7xmvl-vitetris-0.57.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vitetris

Partial log (click to expand)

if [ -n "" ]; then \
  install -d /nix/store/1mcjhd293kqa316xcpwmhws8f7jkqh3f-vitetris-0.57.2/share/allegro && \
  install -m644 pc8x16.fnt /nix/store/1mcjhd293kqa316xcpwmhws8f7jkqh3f-vitetris-0.57.2/share/allegro; fi
Done.
You may also wish to create the system-wide highscore file
with "make install-hiscores".
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/1mcjhd293kqa316xcpwmhws8f7jkqh3f-vitetris-0.57.2/bin
patching script interpreter paths in /nix/store/1mcjhd293kqa316xcpwmhws8f7jkqh3f-vitetris-0.57.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vitetris

Partial log (click to expand)

You may also wish to create the system-wide highscore file
with "make install-hiscores".
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yb95qnp9mbgwdwajdl6c2vrrkg901ay5-vitetris-0.57.2
shrinking /nix/store/yb95qnp9mbgwdwajdl6c2vrrkg901ay5-vitetris-0.57.2/bin/tetris
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yb95qnp9mbgwdwajdl6c2vrrkg901ay5-vitetris-0.57.2/bin
patching script interpreter paths in /nix/store/yb95qnp9mbgwdwajdl6c2vrrkg901ay5-vitetris-0.57.2
checking for references to /build in /nix/store/yb95qnp9mbgwdwajdl6c2vrrkg901ay5-vitetris-0.57.2...
/nix/store/yb95qnp9mbgwdwajdl6c2vrrkg901ay5-vitetris-0.57.2

xeji
xeji approved these changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice retro game, thank you!

@xeji xeji merged commit 1ae5f05 into NixOS:master Aug 27, 2018
@siers
Copy link
Member Author

siers commented Aug 27, 2018

Thanks for merging! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siers @xeji @GrahamcOfBorg