Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat-matrix-bridge: 2018-01-10 -> 2018-05-29 #45667

Merged
merged 1 commit into from Aug 27, 2018
Merged

weechat-matrix-bridge: 2018-01-10 -> 2018-05-29 #45667

merged 1 commit into from Aug 27, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Aug 27, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Ma27

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: weechat-matrix-bridge

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0
shrinking /nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0/lib/lua/5.2/cjson.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0/lib  /nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0/bin
patching script interpreter paths in /nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0
/nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0/bin/json2lua: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/cl52zwbg35c2y63xpzhrxw548qp27dpj-lua-5.2.3/bin/lua"
/nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0/bin/lua2json: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/cl52zwbg35c2y63xpzhrxw548qp27dpj-lua-5.2.3/bin/lua"
checking for references to /build in /nix/store/62b1fm5l358il0sfidgxzdfjs14j38s1-lua5.2-cjson-2.1.0...
cannot build derivation '/nix/store/2sd6nyx5xbalc6b8zkqskpzsa59jlk0x-weechat-matrix-bridge-2018-05-29.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2sd6nyx5xbalc6b8zkqskpzsa59jlk0x-weechat-matrix-bridge-2018-05-29.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: weechat-matrix-bridge

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat-matrix-bridge

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29
shrinking /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/ffi.so
shrinking /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/libolm.so
shrinking /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/cjson.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib
patching script interpreter paths in /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29
checking for references to /build in /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29...
/nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29

@Ma27
Copy link
Member

Ma27 commented Aug 27, 2018

👍 looks reasonable, browsed through the upstream changelog and couldn't find compatibility breaks :)

BTW do you use this package?

@adisbladis
Copy link
Member Author

@Ma27 I just tried it out for the first time today. :)

@adisbladis
Copy link
Member Author

The aarch64 failure is unrelated to this PR.

@adisbladis adisbladis merged commit 0c8f860 into NixOS:master Aug 27, 2018
@Ma27
Copy link
Member

Ma27 commented Aug 27, 2018 •
edited

cool, feel free to ping me if I can help with this package:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @GrahamcOfBorg @Ma27