Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord: 2.0.12 -> 2.0.19 and nixos/trezord: revised and updated udev rules #46658

Closed
wants to merge 7 commits into from
Closed

trezord: 2.0.12 -> 2.0.19 and nixos/trezord: revised and updated udev rules #46658

wants to merge 7 commits into from

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Sep 14, 2018

Motivation for this change

I'd like to maintain the package up-to-date as we're the company releasing the original code.

Things done

Updated version from 2.0.14 to 2.0.19. Reviewed and updated the service policies and rights.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This was referenced Sep 14, 2018
Closed
Closed
Corrected maintainers
5369c8d 
maintainers."1000101"
Missed semicolon
d5036bd 
Missed semicolon
@1000101
Copy link
Member Author

1000101 commented Sep 14, 2018

You're right, thank you so much.

@srhb
Copy link
Contributor

srhb commented Sep 22, 2018

@1000101 Can you give a short description of the purpose of the changes to the udev rules? I'm no udev expert, so it's not obvious to me what's going on.

I'll be happy to merge after this, if it's tested and working. :)

nixos/trezord: updated udev rules for model T
f629d0f 
Model T was not working with 660 rights.
@1000101
Copy link
Member Author

1000101 commented Sep 22, 2018 •
edited

@1000101 Can you give a short description of the purpose of the changes to the udev rules? I'm no udev expert, so it's not obvious to me what's going on.

Hi Sarah! Actually, I'm from the company that is releasing the original source code and since more of us are using NixOS, we'd like to contribute and maintain the package up-to-date.

I'll be happy to merge after this, if it's tested and working. :)

Thanks a lot for asking. I was quite confident that everything is right, but since you've asked I've tested it again and found out that one model of our devices is not quite happy since it wants to use plugdev group (which is not defined by default) instead of dialout. I've committed a fix and tested rebuild on 18.03 by using the local pkgs. Both our devices are now fully functional. Thank you so much, Sarah, I appreciate it!

@1000101
Copy link
Member Author

1000101 commented Sep 24, 2018

@srhb

Hi, I'm closing this PR and opening revised and squashed one for master and backport for 18.03:

master #47289
18.03 #47288

@1000101 1000101 closed this Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1000101 @srhb @7c6f434c @GrahamcOfBorg