Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezord: 2.0.14 -> 2.0.19 and nixos/trezord: revised and updated udev rules #46657

Closed
wants to merge 5 commits into from
Closed

trezord: 2.0.14 -> 2.0.19 and nixos/trezord: revised and updated udev rules #46657

wants to merge 5 commits into from

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Sep 14, 2018

Motivation for this change

I'd like to maintain the package up-to-date as we're the company releasing the original code.

Things done

Updated version from 2.0.14 to 2.0.19. Reviewed and updated the service policies and rights.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Sep 14, 2018 •
edited

Closing as duplicate of #46658

@ryantm ryantm closed this Sep 14, 2018
@7c6f434c
Copy link
Member

@ryantm they have different target branches

@1000101
Copy link
Member Author

1000101 commented Sep 14, 2018 •
edited

Target branch is master, not 18.03 (it's not a duplicate). Should I use some different method for opening pull request into different branch?

@ryantm
Copy link
Member

ryantm commented Sep 14, 2018

Sorry, I didn't realize you had a different target branch!

@ryantm ryantm reopened this Sep 14, 2018
@1000101
Copy link
Member Author

1000101 commented Sep 14, 2018

No worries! If there's a better/preferred way, just let me know!

Corrected maintainers
802ed79 
maintainers."1000101"
@1000101
Copy link
Member Author

1000101 commented Sep 22, 2018

will require further testing for model T

@1000101 1000101 closed this Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1000101 @ryantm @7c6f434c @GrahamcOfBorg