Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fuse: 0.2.1 -> 0.3.1 | refactor | python3 support #46665

Merged
merged 1 commit into from Sep 18, 2018
Merged

pythonPackages.fuse: 0.2.1 -> 0.3.1 | refactor | python3 support #46665

merged 1 commit into from Sep 18, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 15, 2018

Weird, previously the download was named fuse-python and the expression was stored in python-fuse, now the GitHub repository is named python-fuse and the expression directory was changed to fuse-python.

@FRidh
Copy link
Member

FRidh commented Sep 15, 2018

@GrahamcOfBorg build python2.pkgs.fuse python3.pkgs.fuse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.fuse, python3.pkgs.fuse

Partial log (click to expand)

/build/fuse-python-0.3.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d2xmzqqlfgx30y1bgii1padgp7y8468s-python3.6-fuse-python-0.3.1
shrinking /nix/store/d2xmzqqlfgx30y1bgii1padgp7y8468s-python3.6-fuse-python-0.3.1/lib/python3.6/site-packages/fuseparts/_fuse.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d2xmzqqlfgx30y1bgii1padgp7y8468s-python3.6-fuse-python-0.3.1/lib
patching script interpreter paths in /nix/store/d2xmzqqlfgx30y1bgii1padgp7y8468s-python3.6-fuse-python-0.3.1
checking for references to /build in /nix/store/d2xmzqqlfgx30y1bgii1padgp7y8468s-python3.6-fuse-python-0.3.1...
/nix/store/f88ng2855g0qxzpbxk6zdljidla4wxkz-python2.7-fuse-python-0.3.1
/nix/store/d2xmzqqlfgx30y1bgii1padgp7y8468s-python3.6-fuse-python-0.3.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.fuse, python3.pkgs.fuse

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.fuse, python3.pkgs.fuse

Partial log (click to expand)

/build/fuse-python-0.3.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y7b8dn6vyrprp0pscmsmdg53wviz0h6z-python3.6-fuse-python-0.3.1
shrinking /nix/store/y7b8dn6vyrprp0pscmsmdg53wviz0h6z-python3.6-fuse-python-0.3.1/lib/python3.6/site-packages/fuseparts/_fuse.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y7b8dn6vyrprp0pscmsmdg53wviz0h6z-python3.6-fuse-python-0.3.1/lib
patching script interpreter paths in /nix/store/y7b8dn6vyrprp0pscmsmdg53wviz0h6z-python3.6-fuse-python-0.3.1
checking for references to /build in /nix/store/y7b8dn6vyrprp0pscmsmdg53wviz0h6z-python3.6-fuse-python-0.3.1...
/nix/store/3819vz46jgjgx9g26iyp2i86l8bq5r8a-python2.7-fuse-python-0.3.1
/nix/store/y7b8dn6vyrprp0pscmsmdg53wviz0h6z-python3.6-fuse-python-0.3.1

@PsyanticY
Copy link
Contributor Author

@jtojnar I tried to use the same naming in pypi. If you thing we need to keep the old naming then ok.

@FRidh FRidh merged commit de9fb38 into NixOS:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PsyanticY @jtojnar @FRidh @GrahamcOfBorg