findutils: disable a bogus test #46669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: findutils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: findutils Partial log (click to expand)
|
veprbl
force-pushed
the
findutils_fix_staging
branch
from
e6d26da
to
ef04b4f
Compare
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: findutils Partial log (click to expand)
|
|
After some more investigation I found that findutils ships their own |
|
Success on x86_64-linux (full log) Attempted: findutils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: findutils Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: findutils Partial log (click to expand)
|
Mic92
reviewed
Sep 15, 2018
| ASSERT (close (255) == 0); | ||
| ASSERT (close (256) == 0); | ||
| } | ||
| - ASSERT (dup2 (fd, bad_fd - 1) == bad_fd - 1); |
There was a problem hiding this comment.
Is the value of bad_fd also getdtablesize()?
Mic92
reviewed
Sep 15, 2018
| ./no-install-statedir.patch | ||
|
|
||
| # prevent tests from failing on old kernels | ||
| ./disable-getdtablesize-test.patch |
There was a problem hiding this comment.
It might be a good idea to report this also upstream.
There was a problem hiding this comment.
I'm not sure which of the cases should I bring up:
- remove the test
- for them to not use
getdtablesize()fromgnulibthat fall backs on a too high arbitrary guess value whengetrlimitsfails in my case
There was a problem hiding this comment.
No sure, what would you recommend? @jamesyoungman
Mic92
reviewed
Sep 15, 2018
| ./memory-leak.patch | ||
| ./no-install-statedir.patch | ||
|
|
||
| # prevent tests from failing on old kernels |
There was a problem hiding this comment.
It might be also interesting to add here, what your kernel version was (also you don't know the exact one).
There was a problem hiding this comment.
2.6.32-696.18.7.el6.x86_64, and also 2.6.32-754.3.5.el6.x86_64
There was a problem hiding this comment.
@Mic92 These are branches supported by RedHat, they come with backported features as well. I believe the "-754" version came out last month.
|
Success on x86_64-linux (full log) Attempted: findutils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: findutils Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: findutils Partial log (click to expand)
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findutils fails to pass checkPhase on my Linux system that has a
sysconf(_SC_OPEN_MAX)limit set. The test itself appears to be a common copypasta between gnu projects. Poking limits of available fd's is irrelevant to what findutils is designed to do, so I consider the test to be bogus.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)