Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doitlive: 3.0.3 -> 4.0.1 #46668

Merged
merged 4 commits into from Sep 24, 2018
Merged

doitlive: 3.0.3 -> 4.0.1 #46668

merged 4 commits into from Sep 24, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Sep 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mbode mbode requested a review from FRidh as a code owner September 14, 2018 18:43
@Mic92
Copy link
Member

Mic92 commented Sep 15, 2018 

@GrahamcOfBorg build doitlive python27Packages.click-completion python27Packages.click-didyoumean python27Packages.shellingham python36Packages.click-completion python36Packages.click-didyoumean python36Packages.shellingham

Mic92
Mic92 reviewed Sep 15, 2018
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -554,6 +554,8 @@ in {

serversyncstorage = callPackage ../development/python-modules/serversyncstorage {};

shellingham = callPackage ../development/python-modules/shellingham {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put those into individual commits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, also disabled the failing python2 build

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: doitlive, python27Packages.click-completion, python27Packages.click-didyoumean, python27Packages.shellingham, python36Packages.click-completion, python36Packages.click-didyoumean, python36Packages.shellingham

Partial log (click to expand)

Successfully installed doitlive-4.0.1
/build/doitlive-4.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hwd9abghlvnln6gr5r1jp8pqnfcqs1gd-doitlive-4.0.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hwd9abghlvnln6gr5r1jp8pqnfcqs1gd-doitlive-4.0.1/lib  /nix/store/hwd9abghlvnln6gr5r1jp8pqnfcqs1gd-doitlive-4.0.1/bin
patching script interpreter paths in /nix/store/hwd9abghlvnln6gr5r1jp8pqnfcqs1gd-doitlive-4.0.1
checking for references to /build in /nix/store/hwd9abghlvnln6gr5r1jp8pqnfcqs1gd-doitlive-4.0.1...
wrapping `/nix/store/hwd9abghlvnln6gr5r1jp8pqnfcqs1gd-doitlive-4.0.1/bin/doitlive'...
error: build of '/nix/store/7kjmf35mhyfnzhhy9ixmx1p3zygm9kzr-python2.7-click-completion-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: doitlive, python27Packages.click-completion, python27Packages.click-didyoumean, python27Packages.shellingham, python36Packages.click-completion, python36Packages.click-didyoumean, python36Packages.shellingham

Partial log (click to expand)

Successfully installed doitlive-4.0.1
/build/doitlive-4.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9qv8l0chx1zli7jxnbhsdvmj15aj7f9w-doitlive-4.0.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9qv8l0chx1zli7jxnbhsdvmj15aj7f9w-doitlive-4.0.1/lib  /nix/store/9qv8l0chx1zli7jxnbhsdvmj15aj7f9w-doitlive-4.0.1/bin
patching script interpreter paths in /nix/store/9qv8l0chx1zli7jxnbhsdvmj15aj7f9w-doitlive-4.0.1
checking for references to /build in /nix/store/9qv8l0chx1zli7jxnbhsdvmj15aj7f9w-doitlive-4.0.1...
wrapping `/nix/store/9qv8l0chx1zli7jxnbhsdvmj15aj7f9w-doitlive-4.0.1/bin/doitlive'...
error: build of '/nix/store/4cp69qf58qm9zad6gbf7n7y4x2wrz9s6-python2.7-click-completion-0.4.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: doitlive, python27Packages.click-completion, python27Packages.click-didyoumean, python27Packages.shellingham, python36Packages.click-completion, python36Packages.click-didyoumean, python36Packages.shellingham

Partial log (click to expand)

  The script doitlive is installed in '/nix/store/qxpp3nhrwr4r1387k964wpacp7406kjn-doitlive-4.0.1/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed doitlive-4.0.1
/private/tmp/nix-build-doitlive-4.0.1.drv-0/doitlive-4.0.1
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qxpp3nhrwr4r1387k964wpacp7406kjn-doitlive-4.0.1/lib  /nix/store/qxpp3nhrwr4r1387k964wpacp7406kjn-doitlive-4.0.1/bin
patching script interpreter paths in /nix/store/qxpp3nhrwr4r1387k964wpacp7406kjn-doitlive-4.0.1
wrapping `/nix/store/qxpp3nhrwr4r1387k964wpacp7406kjn-doitlive-4.0.1/bin/doitlive'...
error: build of '/nix/store/qkp5jg2648hawfncij7rgqh29l7vclzl-python2.7-click-completion-0.4.1.drv' failed

@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

@GrahamcOfBorg build doitlive python27Packages.click-completion python27Packages.click-didyoumean python27Packages.shellingham python36Packages.click-completion python36Packages.click-didyoumean python36Packages.shellingham

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: doitlive, python27Packages.click-didyoumean, python27Packages.shellingham, python36Packages.click-completion, python36Packages.click-didyoumean, python36Packages.shellingham

The following builds were skipped because they don't evaluate on x86_64-linux: python27Packages.click-completion

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/25rb64jn44zlpv38w0h9zq43y8sz8bph-doitlive-4.0.1/lib  /nix/store/25rb64jn44zlpv38w0h9zq43y8sz8bph-doitlive-4.0.1/bin
patching script interpreter paths in /nix/store/25rb64jn44zlpv38w0h9zq43y8sz8bph-doitlive-4.0.1
checking for references to /build in /nix/store/25rb64jn44zlpv38w0h9zq43y8sz8bph-doitlive-4.0.1...
wrapping `/nix/store/25rb64jn44zlpv38w0h9zq43y8sz8bph-doitlive-4.0.1/bin/doitlive'...
/nix/store/25rb64jn44zlpv38w0h9zq43y8sz8bph-doitlive-4.0.1
/nix/store/klpz163d80lyv7x2ihy7zlh2k8487nc7-python2.7-click-didyoumean-0.0.3
/nix/store/hzg5phgxa954p7mrbgsgc32ap2k3dyaj-python2.7-shellingham-1.2.6
/nix/store/sbjb5lc0xvw01gara85s31ckjj0a0cgn-python3.6-click-completion-0.4.1
/nix/store/388lx4i6chrrrcc5h4amjd95g924i9gn-python3.6-click-didyoumean-0.0.3
/nix/store/fwjdbg5qn7nwbn2iybz7f20ylpk4g5sm-python3.6-shellingham-1.2.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: doitlive, python27Packages.click-didyoumean, python27Packages.shellingham, python36Packages.click-completion, python36Packages.click-didyoumean, python36Packages.shellingham

The following builds were skipped because they don't evaluate on aarch64-linux: python27Packages.click-completion

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/i8xy774s80dfy9y1ilcj4yx87dyaxlpr-doitlive-4.0.1/lib  /nix/store/i8xy774s80dfy9y1ilcj4yx87dyaxlpr-doitlive-4.0.1/bin
patching script interpreter paths in /nix/store/i8xy774s80dfy9y1ilcj4yx87dyaxlpr-doitlive-4.0.1
checking for references to /build in /nix/store/i8xy774s80dfy9y1ilcj4yx87dyaxlpr-doitlive-4.0.1...
wrapping `/nix/store/i8xy774s80dfy9y1ilcj4yx87dyaxlpr-doitlive-4.0.1/bin/doitlive'...
/nix/store/i8xy774s80dfy9y1ilcj4yx87dyaxlpr-doitlive-4.0.1
/nix/store/7rbgp4hifcvw3cl2x5lsf8fvjgxn1608-python2.7-click-didyoumean-0.0.3
/nix/store/z9ln9bm3zkclwwv0q1x1h1cd3ymrzf6x-python2.7-shellingham-1.2.6
/nix/store/jvkqqm4ya26hyy0ij9kk83xzgwf757ba-python3.6-click-completion-0.4.1
/nix/store/y1jyndxpjcciaxzbjdrvma0bwavjm60v-python3.6-click-didyoumean-0.0.3
/nix/store/00dq3vf1sd8my068vrd4vs8yf4y4ckrs-python3.6-shellingham-1.2.6

@Ekleog
Copy link
Member

Ekleog commented Sep 24, 2018

(from triage) Looks ready to me, though I can't call the tests on darwin.

@Mic92 Mic92 merged commit 3e270ff into NixOS:master Sep 24, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

Thanks!

@mbode mbode deleted the doitlive_4 branch September 29, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mbode @Mic92 @GrahamcOfBorg @Ekleog @FRidh