Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newtonsoft.Json: 6.0.8 -> 11.0.2 #46679

Merged
merged 1 commit into from Sep 14, 2018
Merged

Newtonsoft.Json: 6.0.8 -> 11.0.2 #46679

merged 1 commit into from Sep 14, 2018

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Sep 14, 2018 •
edited

Motivation for this change

This upgrades Newtonsoft.Json and fixes a few failing packages, among which openra.

I cherry-picked c632384 as @matthewbauer suggested.

This is based on #44478.
This replaces #46425
This is part of #45960

Ping @samueldr @nek0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 14, 2018

@GrahamcOfBorg build dotnetPackages.NewtonsoftJson openra

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dotnetPackages.NewtonsoftJson, openra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dotnetPackages.NewtonsoftJson

The following builds were skipped because they don't evaluate on x86_64-darwin: openra

Partial log (click to expand)

'package/services' -> '/nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2/lib/dotnet/Newtonsoft.Json/package/services'
'package/services/metadata' -> '/nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2/lib/dotnet/Newtonsoft.Json/package/services/metadata'
'package/services/metadata/core-properties' -> '/nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2/lib/dotnet/Newtonsoft.Json/package/services/metadata/core-properties'
'package/services/metadata/core-properties/620e2bc63eca44f08a90b7f8a29c7d5e.psmdcp' -> '/nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2/lib/dotnet/Newtonsoft.Json/package/services/metadata/core-properties/620e2bc63eca44f08a90b7f8a29c7d5e.psmdcp'
/nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2 /private/tmp/nix-build-Newtonsoft.Json-11.0.2.drv-0
/private/tmp/nix-build-Newtonsoft.Json-11.0.2.drv-0
glibPreFixupPhase
post-installation fixup
patching script interpreter paths in /nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2
/nix/store/13dv0fh294x139j3xjs67f8p2nmpv9by-Newtonsoft.Json-11.0.2

@xeji xeji mentioned this pull request Sep 14, 2018
Closed
9 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dotnetPackages.NewtonsoftJson, openra

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307
gzipping man pages under /nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307/share/man/
patching script interpreter paths in /nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307
/nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307/lib/openra/launch-dedicated.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307/lib/openra/.launch-game.sh-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307...
/nix/store/jsl9bl7vgvsi4s8ngwpprdyafz6b844x-Newtonsoft.Json-11.0.2
/nix/store/7yzg50y6ibrw25957b0305rm9rnycyd9-openra-20180307

@xeji
Copy link
Contributor

xeji commented Sep 14, 2018

@GrahamcOfBorg build dotnetPackages.Paket dotnetPackages.FSharpAutoComplete gdata-sharp

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dotnetPackages.Paket, dotnetPackages.FSharpAutoComplete, gdata-sharp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dotnetPackages.Paket, dotnetPackages.FSharpAutoComplete, gdata-sharp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: dotnetPackages.Paket, dotnetPackages.FSharpAutoComplete, gdata-sharp

Partial log (click to expand)

src/unittests/picasa/TagAccessorTest.cs(12,6): error CS0619: `NUnit.Framework.TestFixtureAttribute' is obsolete: `The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
src/unittests/picasa/GPhotoMaxPhotosPerAlbumTest.cs(14,6): error CS0619: `NUnit.Framework.TestFixtureAttribute' is obsolete: `The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
src/unittests/picasa/PicasaQueryTest.cs(33,6): error CS0619: `NUnit.Framework.TestFixtureAttribute' is obsolete: `The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
src/unittests/picasa/GPhotoBytesUsedTest.cs(14,6): error CS0619: `NUnit.Framework.TestFixtureAttribute' is obsolete: `The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
src/unittests/picasa/GPhotoExtensionsTest.cs(14,6): error CS0619: `NUnit.Framework.TestFixtureAttribute' is obsolete: `The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
src/unittests/picasa/PicasaFeedTest.cs(15,6): error CS0619: `NUnit.Framework.TestFixtureAttribute' is obsolete: `The NUnit framework shipped with Mono is deprecated and will be removed in a future release. It was based on NUnit 2.4 which is long outdated. Please move to the NUnit NuGet package or some other form of acquiring NUnit.'
Compilation failed: 181 error(s), 12 warnings
make: *** [Makefile:122: tests] Error 1
builder for '/nix/store/0lxqgq2n0dzvwpr347jvibycj9c8zcjx-gdata-sharp-2.2.0.0.drv' failed with exit code 2
error: build of '/nix/store/0lxqgq2n0dzvwpr347jvibycj9c8zcjx-gdata-sharp-2.2.0.0.drv', '/nix/store/dmdlpc8s2cjs9r26n9346v5cngwmdb8c-Paket-1.18.2.drv', '/nix/store/xggs5l71a39dyxllr7yr6i5a5yfr2zp8-FSharp.AutoComplete-0.18.2.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 14, 2018

The last 3 failures shouldn't prevent merging this, they can be fixed separately, maybe just need an update. They've been broken since April 2018 anyway because of NewtonsoftJson ...

@xeji xeji merged commit fb11065 into NixOS:master Sep 14, 2018
xeji pushed a commit that referenced this pull request Sep 14, 2018
@bobvanderlinden @xeji
Newtonsoft.Json: 6.0.8 -> 11.0.2 (#46679)
b998319 
(cherry picked from commit fb11065)
@xeji
Copy link
Contributor

xeji commented Sep 14, 2018

backported: b998319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @xeji @GrahamcOfBorg