Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php71: 7.1.21 -> 7.1.22 #46697

Closed
wants to merge 1 commit into from
Closed

php71: 7.1.21 -> 7.1.22 #46697

wants to merge 1 commit into from

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 15, 2018

Motivation for this change

Changelog: https://secure.php.net/ChangeLog-7.php#7.1.22

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22...
moving /nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22/sbin/* to /nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/91wik8hb8hnib6f0y6ygkhmny5gday3z-php-7.1.22-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/91wik8hb8hnib6f0y6ygkhmny5gday3z-php-7.1.22-dev
checking for references to /build in /nix/store/91wik8hb8hnib6f0y6ygkhmny5gday3z-php-7.1.22-dev...
/nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22...
moving /nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22/sbin/* to /nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/fzvg6yrvrbsrdwh8y48frx07dnkfdp46-php-7.1.22-dev
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/fzvg6yrvrbsrdwh8y48frx07dnkfdp46-php-7.1.22-dev
checking for references to /build in /nix/store/fzvg6yrvrbsrdwh8y48frx07dnkfdp46-php-7.1.22-dev...
/nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018

@GrahamcOfBorg build php71

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/fh2rz2r4zzyw4waki8iy4ymzsg3ilb0r-php-7.1.22

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/fsy37l7pf4n8cpxdxz3bwgqmcb5m9j8s-php-7.1.22

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: php71

Partial log (click to expand)

/private/tmp/nix-build-php-7.1.22.drv-0/php-7.1.22/main/php_config.h:2548:24: note: expanded from macro 'zend_finite'
#define zend_finite(a) finite(a)
                       ^
/nix/store/qjmqrzk8nhn5maa093fhl3finczz72lw-libc++-5.0.2/include/c++/v1/math.h:439:1: note: 'isfinite' declared here
isfinite(_A1 __lcpp_x) _NOEXCEPT
^
2 errors generated.
make: *** [Makefile:1169: ext/intl/intl_convertcpp.lo] Error 1
builder for '/nix/store/2ivf41f98jsvkmqscdwz94rpji8kqgwl-php-7.1.22.drv' failed with exit code 2
error: build of '/nix/store/2ivf41f98jsvkmqscdwz94rpji8kqgwl-php-7.1.22.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 15, 2018 •
edited

Same bug here as in php72, see #46694

@etu etu mentioned this pull request Sep 15, 2018
Merged
9 tasks
@etu etu closed this Sep 15, 2018
@etu etu deleted the upgrade-php-7122 branch September 15, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @xeji