Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apacheKafka: 1.1.0 -> 2.0.0, various patch upgrades for other versions #46690

Merged
merged 5 commits into from Sep 15, 2018
Merged

apacheKafka: 1.1.0 -> 2.0.0, various patch upgrades for other versions #46690

merged 5 commits into from Sep 15, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Sep 15, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mbode
Copy link
Contributor Author

mbode commented Sep 15, 2018

I am not sure what the policy is on how many old versions should be kept, cf. discussion in #46659.

Also, it seems there are so far no mentions of Kafka version upgrades in the release notes, is that on purpose?

@NeQuissimus
Copy link
Member

@GrahamcOfBorg test kafka

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.kafka

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.kafka

No partial log is available.

@NeQuissimus NeQuissimus merged commit 5e21a5a into NixOS:master Sep 15, 2018
@mbode
Copy link
Contributor Author

mbode commented Sep 22, 2018

@NeQuissimus It seems you only pushed one of the commits to master

@NeQuissimus
Copy link
Member

oO That's the weirdest thing! I just used the GitHub UI...

@NeQuissimus
Copy link
Member

Looks like they all made it in, though, I can see Kafka 2.0 in master

@mbode
Copy link
Contributor Author

mbode commented Sep 22, 2018

Oh sorry, I should've checked there first!

@mbode mbode deleted the kafka_2 branch September 22, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @NeQuissimus @GrahamcOfBorg