Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afew: add manpage #46661

Merged
merged 1 commit into from Sep 14, 2018
Merged

afew: add manpage #46661

merged 1 commit into from Sep 14, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 14, 2018

Motivation for this change

Generate the afew manpage which was previously missing.
(I did not add a separate man output, not worth it for a single 9kB manpage.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • impact on closure size: +9kB
  • Fits CONTRIBUTING.md.

cc maintainers @andir @flokli @garbas

@xeji
afew: add manpage
283e080 
Generate the manpage which was previously missing.
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: afew

Partial log (click to expand)

test_add_FilterRegistry (afew.tests.test_settings.TestFilterRegistry) ... ok
test_all_builtin_FilterRegistrys_exist (afew.tests.test_settings.TestFilterRegistry) ... ok
test_all_filters_exist (afew.tests.test_settings.TestFilterRegistry) ... ok
test_entry_point_registration (afew.tests.test_settings.TestFilterRegistry) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.086s

OK
/nix/store/wzba2kjdcav70x8bfcna6vig0nhzxqps-afew-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: afew

Partial log (click to expand)

test_add_FilterRegistry (afew.tests.test_settings.TestFilterRegistry) ... ok
test_all_builtin_FilterRegistrys_exist (afew.tests.test_settings.TestFilterRegistry) ... ok
test_all_filters_exist (afew.tests.test_settings.TestFilterRegistry) ... ok
test_entry_point_registration (afew.tests.test_settings.TestFilterRegistry) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.366s

OK
/nix/store/5gq1rr6ii86p705sb7b2vx59hk0zqic2-afew-1.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: afew

Partial log (click to expand)

test_add_FilterRegistry (afew.tests.test_settings.TestFilterRegistry) ... ok
test_all_builtin_FilterRegistrys_exist (afew.tests.test_settings.TestFilterRegistry) ... ok
test_all_filters_exist (afew.tests.test_settings.TestFilterRegistry) ... ok
test_entry_point_registration (afew.tests.test_settings.TestFilterRegistry) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.905s

OK
/nix/store/4xv27v40c8wsjrrsijprhngkhqa5brzv-afew-1.3.0

@garbas garbas merged commit 541b241 into NixOS:master Sep 14, 2018
@xeji xeji deleted the p/afew-man branch September 14, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @garbas